Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plausible): domain update #380

Closed
wants to merge 1 commit into from

Conversation

theJohnnyMe
Copy link
Contributor

@theJohnnyMe theJohnnyMe commented Oct 24, 2023

Describe pull-request
Updating Plausible domain for develop branch

Solving issue
Fixes: CDEP-2890

How to test

  1. Check if the domain in code changes is updated to new one (tds-storybook.tegel.scania.com)

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aws-amplify-eu-north-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-380.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

@alexandereneroth alexandereneroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest two PRs as you did, but with the same branch, otherwise git will still consider them out of sync, even if they contain the same changes.
We also might have to remove the branch auto deletion on merge.

@theJohnnyMe
Copy link
Contributor Author

I suggest two PRs as you did, but with the same branch, otherwise git will still consider them out of sync, even if they contain the same changes. We also might have to remove the branch auto deletion on merge.

Good that you commented. I would propose this:

  1. Close this PR
  2. Merge changes to the main branch so we get tracking in the place (in other PR)
  3. Rebase develop with main so develop has whatever main has + its new changes
  4. Live happily ever after

@alexandereneroth - what do you think of this approach?
I think I can do it as I can bypass GitHub rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants