Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update create-release-pr job #420

Merged
merged 10 commits into from
Nov 15, 2023

Conversation

alexandereneroth
Copy link
Contributor

@alexandereneroth alexandereneroth commented Nov 13, 2023

This PR updates the release pipeline so it works (please work 🙏).

Solving issue
Fixes: CDEP-2970

How to test
Not really possible to test.
Maybe just read through the files and check if something looks off to you.

Additional context
Our last release with these workflows failed miserably - hence the update.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-420.d3fazya28914g3.amplifyapp.com

Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexandereneroth
Copy link
Contributor Author

@theJohnnyMe Also activated prettier for the workflow files to future proof it.

Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Alex!

@alexandereneroth alexandereneroth merged commit 2afd3a5 into develop Nov 15, 2023
3 checks passed
@alexandereneroth alexandereneroth deleted the chore/CDEP-2970-fix-release-pipeline branch November 15, 2023 13:17
@alexandereneroth alexandereneroth restored the chore/CDEP-2970-fix-release-pipeline branch November 15, 2023 13:21
@alexandereneroth alexandereneroth deleted the chore/CDEP-2970-fix-release-pipeline branch November 15, 2023 13:22
alexandereneroth added a commit that referenced this pull request Nov 16, 2023
* chore: update create-release-pr job

* chore: update create-release-pr job

* chore: disable creating major releases

* chore: update release-core workflow

* chore: temporarily allow workflow on wrong branch

* chore: stop using deprecated way to set output

* chore: update release workflows, rename

* chore(release action): allow any branch

* Revert "chore(release action): allow any branch"

This reverts commit dac49bf.

* style: formatting

---------

Co-authored-by: Default <alex.john.eneroth@gmail.om>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants