Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cleanup #95

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

some cleanup #95

wants to merge 9 commits into from

Commits on May 4, 2012

  1. var statement was closed too early

    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    e82c0f2 View commit details
    Browse the repository at this point in the history

  2. missing semicolon on assignment

    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    e3cba4e View commit details
    Browse the repository at this point in the history

  3. escape curly brackets 

    curly brackets have special meaning in regular expressions and should be
escaped when used as literal strings
    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    d973bc3 View commit details
    Browse the repository at this point in the history

  4. added missing semicolons

    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    1073f09 View commit details
    Browse the repository at this point in the history

  5. give radix when using parseInt 

    See
http://nicolaasmatthijs.blogspot.de/2009/05/missing-radix-parameter.html
for why that might be important
    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    05d31ea View commit details
    Browse the repository at this point in the history

  6. another missing semicolon

    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    f7673f4 View commit details
    Browse the repository at this point in the history

  7. removed unecessary semicolons 

    Semicolons are only needed to terminate statements and assignments, they
are not needed for control structures or function bodies (except the
function is defined by assigning a closure, then it's an assignment
again)
    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    9c8698c View commit details
    Browse the repository at this point in the history

  8. fixed image references 

    some image files used uppercase extensions (.JPG) which will not work on
file sensitive filesystems.
    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    60a7144 View commit details
    Browse the repository at this point in the history

  9. removed ad code 

    this caused javascript errors for me
    @splitbrain
    splitbrain committed May 4, 2012
    Copy the full SHA
    128933b View commit details
    Browse the repository at this point in the history