Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support systemd and fix the build on Ubuntu 16.04 #61

Merged
merged 8 commits into from
May 28, 2016

Conversation

metalefty
Copy link
Collaborator

Call for volunteers. Would someone like to test this branch?

$ git clone -b ubuntu-16.04 https://github.com/metalefty/X11RDP-o-Matic.git
$ cd X11RDP-o-Matic
# ./X11RDP-o-Matic.sh --justdoit --branch devel  # master branch will fail, not a o-Matic bug.

If you have time, results of with --nox11rdp are welcome.

# ./X11RDP-o-Matic.sh --justdoit --branch devel --nox11rdp

At least build should be succeed on:

  • Ubuntu 16.04, 15.10, 15.04, 14.04, 12.04
  • Debian GNU/Linux 8.0, 7.0

At least these two points should be checked:

  • build successfully finished with no errors
  • xrdp is running when o-Matic successfully finished

If no problem, I'll merge this and close #60.

old version of dh_make does not support "-y" option
but use of "echo | dh_make" for new version in
Ubuntu 16.04 generates error
check if libtool-bin package exists before adding it to
REQUIRED PACKAGE
@nerdknight
Copy link

On Ubuntu 16.04 failed, here is the output:

config.status: creating config_ac.h
config.status: executing depfiles commands
config.status: executing libtool commands
| dh_make --single --copyright apache --createorig
./X11rdp-o-matic.sh: line 520: cd: debian: No such file or directory

@@ -130,6 +130,11 @@ else
USING_SYSTEMD=true
fi

# change dh_make option depending on if dh_make supports -y option
dh_make -h | grep -q -- -y && \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dh_make should be installed before doing this.

@metalefty
Copy link
Collaborator Author

Run X11RDP-o-Matic.sh again, it will succeed.

But this is indeed a bug. I'll fix it later.

previous code fails if dh_make is not installed yet.
@metalefty
Copy link
Collaborator Author

@nerdknight Fixed. Deinstall dh-make package and could you try again?

@coolemza
Copy link

xubuntu 16.04 - everything ok

@nerdknight
Copy link

It works ok now on Ubuntu 16.04

@metalefty
Copy link
Collaborator Author

Thanks, still waiting for testing on older Ubuntu and Debian.

@nerdknight
Copy link

Works ok on Ubuntu 14.04

@metalefty
Copy link
Collaborator Author

Works on Debian 8.4.

@metalefty metalefty merged commit d10bde7 into scarygliders:devel May 28, 2016
@metalefty
Copy link
Collaborator Author

I'll merge develop into master in a few days.

@johnpeak
Copy link

This looks like it was merged back into the devel branch, but I still get same error on debian 8.7. I clone the repo and ran "./X11RDP-o-matic.sh --justdoit --branch devel". I suspect I'm doing something wrong though. Any ideas?

@ZevSuk
Copy link

ZevSuk commented Apr 5, 2017

run "git clone -b ubuntu-16.04 https://github.com/metalefty/XllRDP-o-Matic.git"
Cloning into "XllRDP-o-Matic'...
fatal: Remote branch ubuntu-16.04 not found in upstream origin

I still did not understand.
Is there a support for ubuntu-16 x64 or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants