-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support systemd and fix the build on Ubuntu 16.04 #61
Conversation
old version of dh_make does not support "-y" option but use of "echo | dh_make" for new version in Ubuntu 16.04 generates error
check if libtool-bin package exists before adding it to REQUIRED PACKAGE
On Ubuntu 16.04 failed, here is the output:
|
@@ -130,6 +130,11 @@ else | |||
USING_SYSTEMD=true | |||
fi | |||
|
|||
# change dh_make option depending on if dh_make supports -y option | |||
dh_make -h | grep -q -- -y && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dh_make should be installed before doing this.
Run X11RDP-o-Matic.sh again, it will succeed. But this is indeed a bug. I'll fix it later. |
previous code fails if dh_make is not installed yet.
@nerdknight Fixed. Deinstall dh-make package and could you try again? |
xubuntu 16.04 - everything ok |
It works ok now on Ubuntu 16.04 |
Thanks, still waiting for testing on older Ubuntu and Debian. |
Works ok on Ubuntu 14.04 |
Works on Debian 8.4. |
I'll merge develop into master in a few days. |
This looks like it was merged back into the devel branch, but I still get same error on debian 8.7. I clone the repo and ran "./X11RDP-o-matic.sh --justdoit --branch devel". I suspect I'm doing something wrong though. Any ideas? |
run "git clone -b ubuntu-16.04 https://github.com/metalefty/XllRDP-o-Matic.git" I still did not understand. |
Call for volunteers. Would someone like to test this branch?
If you have time, results of with
--nox11rdp
are welcome.At least build should be succeed on:
At least these two points should be checked:
If no problem, I'll merge this and close #60.