Improve Version Handling in Build & Backend #1043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use resource processing of gradle to put version numbers into version properties file in resources 2. use same approach to also include the version numbers in spring application banner 3. apply idea plugin in gradle to ensure the same output dirs are used in intellij 4. extract the calculation of scenarioo version numbers into own version.gradle file 5. use standard gradle version property in gradle files where appropriate
…ess' of https://github.com/scenarioo/scenarioo into feature/cleanup_gradle_config_version_mess � Conflicts: � scenarioo-server/build.gradle
danielsuter
requested changes
Jun 27, 2021
|
|
||
| ext.versionWithGitCommit = getVersionName(); | ||
| apply plugin: 'idea' |
| 'aggregatedDataFormatVersion=' + aggregatedDataFormatVersion + '\n' + | ||
| 'documentationVersion=' + documentationVersion + '\n') | ||
| /** | ||
| * Replace properties in important resource files |
There was a problem hiding this comment.
I think java doc style should only be used on methods. I would use a /* single comment */ style here.
| @@ -160,7 +152,7 @@ publishing { | |||
|
|
|||
| groupId 'org.scenarioo' | |||
| artifactId 'scenarioo-viewer' | |||
| version versionWithGitCommit | |||
| version scenariooViewerVersion | |||
There was a problem hiding this comment.
this is the same as archiveVersion, correct?
| public class ApplicationVersionHolderTest { | ||
|
|
||
| @Test | ||
| public void initializeFromClassContext_loadsVersionProperlyFromVersionPropertiesFile() { |
There was a problem hiding this comment.
JUnit 5 does not require the public keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the version handling in several aspects: