Remove workaround for tableView(_:didSelectRowAt:) issue #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround was added to avoid `tableView(_:didSelectRowAt:)` not being called on first tap after the moving animation. However, it doesn't only resolved the issue, but also has side effects. For example, it affects the seamless scrolling in dragging up a panel from half to full after bouncing it in the bottom buffer. The problem occurs on "Tab2" sample of "Show Tab Bar". Moreover the UITableView issue seems to be relieved on iOS 13. Therefore I remove the workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround was added to avoid
tableView(_:didSelectRowAt:)notbeing called on first tap after the moving animation. However, it
doesn't only resolved the issue, but also has side effects.
For example, it affects the seamless scrolling in dragging up a panel from
half to full after bouncing it in the bottom buffer. The problem occurs
on "Tab2" sample of "Show Tab Bar".
Moreover the UITableView issue seems to be relieved on iOS 13.
Therefore I remove the workaround.