Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for tableView(_:didSelectRowAt:) issue #225

Merged
merged 1 commit into from
Jun 19, 2019

Commits on Jun 19, 2019

  1. Remove workaround for tableView(_:didSelectRowAt:) issue

    The workaround was added to avoid `tableView(_:didSelectRowAt:)` not
    being called on first tap after the moving animation. However, it
    doesn't only resolved the issue, but also has side effects.
    
    For example, it affects the seamless scrolling in dragging up a panel from
    half to full after bouncing it in the bottom buffer. The problem occurs
    on "Tab2" sample of "Show Tab Bar".
    
    Moreover the UITableView issue seems to be relieved on iOS 13.
    
    Therefore I remove the workaround.
    scenee committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    656bbc1 View commit details
    Browse the repository at this point in the history