Fix potential leaks in presenting/dismissing a panel modally. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dismisses the frame 'FloatingPanel Core.move(from:to:animated:completion:)' in the following memory leaks > BoardServices -[BSXPCServiceConnectionEventHandler remoteTarget] > BoardServices __63+[BSXPCServiceConnectionProxy createImplementationForProtocol:]_block_invoke These leaks happens when a panel showes and hides using "Show Multi Panel Modal" in the Samples app.
scenee
force-pushed
the
fix-potential-leaks
branch
from
046bd99
to
217394a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dismisses the frame 'FloatingPanel Core.move(from:to:animated:completion:)' in the following memory leaks
These leaks happens when a panel showes and hides using "Show Multi Panel Modal" in the Samples app.