Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential leaks in presenting/dismissing a panel modally. #429

Merged
merged 1 commit into from
Feb 6, 2021

Commits on Jan 15, 2021

  1. Prevent the potential memory leaks in the modal transition

    This dismisses the frame 'FloatingPanel Core.move(from:to:animated:completion:)'
    in the following memory leaks
    
    > BoardServices -[BSXPCServiceConnectionEventHandler remoteTarget]
    > BoardServices __63+[BSXPCServiceConnectionProxy createImplementationForProtocol:]_block_invoke
    
    These leaks happens when a panel showes and hides using "Show Multi Panel Modal"
    in the Samples app.
    scenee committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    217394a View commit details
    Browse the repository at this point in the history