Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a second volume seems to duplicate the first one #422

Closed
frauzufall opened this issue Oct 25, 2021 · 7 comments
Closed

Adding a second volume seems to duplicate the first one #422

frauzufall opened this issue Oct 25, 2021 · 7 comments
Assignees
Labels
1.0.0 1.0.0 release bug high-priority verified Bugs or issues that have been verified
Milestone

Comments

@frauzufall
Copy link
Collaborator

Starting the VolumeRenderDemo and adding a new volume (using the T1 head) adds a blurry (?!) version of the first volume and slows down my machine drastically.

image

@kephale kephale added needs-verification This issue needs additional information or confirmation 1.0.0 1.0.0 release verified Bugs or issues that have been verified and removed needs-verification This issue needs additional information or confirmation labels Jun 10, 2023
@moreApi
Copy link
Member

moreApi commented Jun 12, 2023

Not sure if it is a second volume. But there is defnitly something wrong with visibilty. I can only hide all or none of the volumes by setting all volumes to visible. As long as one volume is set to visibible all volumes are visible.

@kephale
Copy link
Member

kephale commented Jun 12, 2023

@moreApi that sounds different, this bug is:

Run mesh demo: see the cube volume
Add T1 head: another cube is added to the scene and there is no head.

@moreApi
Copy link
Member

moreApi commented Jun 12, 2023

Then I cant repoduce the bug. For me the head is added but it is hidden by a very small scale and transparent transfer function. But that is expected behavior in my experience.

@moreApi
Copy link
Member

moreApi commented Jun 12, 2023

I added the head by opening the sample in imageJ and then using "add->volume" in sciview

@kephale
Copy link
Member

kephale commented Jun 12, 2023

@moreApi you are very correct. I now understand why the visibility part is the main issue here.

If you delete the cube volume, then you can see the T1 head without doing anything with visibility.

@moreApi moreApi self-assigned this Jun 12, 2023
moreApi added a commit to scenerygraphics/scenery that referenced this issue Jun 13, 2023
…g: Respect Volume visibilty of the volume node.

Add sceneGraphVisibility per volume shader uniform. Should solve scenerygraphics/sciview#422
@moreApi
Copy link
Member

moreApi commented Jun 13, 2023

should be solved by scenerygraphics/scenery#544 once merged

skalarproduktraum pushed a commit to scenerygraphics/scenery that referenced this issue Jun 14, 2023
…g: Respect Volume visibilty of the volume node.

Add sceneGraphVisibility per volume shader uniform. Should solve scenerygraphics/sciview#422
@moreApi moreApi added this to the unscheduled milestone Jun 16, 2023
elect86 pushed a commit to scenerygraphics/scenery that referenced this issue Jun 27, 2023
…g: Respect Volume visibilty of the volume node.

Add sceneGraphVisibility per volume shader uniform. Should solve scenerygraphics/sciview#422
@kephale
Copy link
Member

kephale commented Jul 15, 2023

This was closed by updates for scenery 0.9.0. I tested on commit d50e2a8e920ace13b09dd0ed9e4f02646d8dd443

image

@kephale kephale closed this as completed Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 1.0.0 release bug high-priority verified Bugs or issues that have been verified
Projects
None yet
Development

No branches or pull requests

3 participants