Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle catalog #379

Merged
merged 13 commits into from
May 15, 2021
Merged

Gradle catalog #379

merged 13 commits into from
May 15, 2021

Conversation

elect86
Copy link
Member

@elect86 elect86 commented Apr 27, 2021 •
edited
Loading

  • Gradle 7.0
  • Gradle Catalog centralized versions, safe-type dependency accessors
  • relying on a more vanilla Gradle api (::implementation instead ::sciJava)
  • sciJava plugin alignment (against 30.0.0, with a small deviation), workaround for jitpack issue

elect86 and others added 12 commits April 27, 2021 06:41
skalarproduktraum
skalarproduktraum requested changes May 10, 2021
View reviewed changes
Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small change, plus maybe cleaning up the comments in the build.gradle.kts a bit?

build.gradle.kts Outdated

api("graphics.scenery:scenery:$sceneryVersion")
// api("com.github.scenerygraphics:scenery:$sceneryVersion")
val scenery = "96e8a96"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call this sceneryVersion, or is there a reason why it needs to be just scenery?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't

@kephale kephale merged commit 578227e into master May 15, 2021
@skalarproduktraum skalarproduktraum deleted the gradleCatalog branch August 10, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skalarproduktraum skalarproduktraum skalarproduktraum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elect86 @skalarproduktraum @kephale