Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitpack pom #399

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Jitpack pom #399

merged 6 commits into from
Sep 14, 2021

Conversation

kephale
Copy link
Member

@kephale kephale commented Aug 24, 2021

Manually adding <type>pom</type> to lwjgl-pom and kotlin-pom fixes dependency resolution issues, but then there is a runtime jackson issue

@kephale
Copy link
Member Author

kephale commented Aug 24, 2021

This is the jackson error, need to track it down:

Exception in thread "main" java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/TSFBuilder
	at java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.util.concurrent.FutureTask.get(FutureTask.java:192)
	at sc.iview.DefaultSciViewService.makeSciView(DefaultSciViewService.java:127)
	at sc.iview.DefaultSciViewService.getOrCreateActiveSciView(DefaultSciViewService.java:175)
	at sc.iview.SciView$Companion.create(SciView.kt:1675)
	at sc.iview.SciView.create(SciView.kt)
	at sc.iview.minimal.MyDemo.main(MyDemo.java:63)
Caused by: java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/TSFBuilder
	at graphics.scenery.backends.RenderConfigReader.loadFromFile(RenderConfigReader.kt:180)
	at graphics.scenery.backends.vulkan.VulkanRenderer.setRenderConfigFile(VulkanRenderer.kt:401)
	at graphics.scenery.backends.vulkan.VulkanRenderer.<init>(VulkanRenderer.kt:472)
	at graphics.scenery.backends.Renderer$Companion.createRenderer(Renderer.kt:268)
	at graphics.scenery.backends.Renderer$Companion.createRenderer$default(Renderer.kt:250)
	at sc.iview.ui.SwingMainWindow.<init>(SwingMainWindow.kt:217)
	at sc.iview.SciView.init(SciView.kt:384)
	at graphics.scenery.SceneryBase.sceneryMain$suspendImpl(SceneryBase.kt:226)
	at graphics.scenery.SceneryBase.sceneryMain(SceneryBase.kt)
	at graphics.scenery.SceneryBase$main$1.invokeSuspend(SceneryBase.kt:504)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:274)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:85)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at graphics.scenery.SceneryBase.main(SceneryBase.kt:504)
	at sc.iview.DefaultSciViewService.lambda$makeSciView$0(DefaultSciViewService.java:114)
	at org.scijava.thread.DefaultThreadService.lambda$wrap$1(DefaultThreadService.java:211)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.core.TSFBuilder
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	... 26 more

@kephale
Copy link
Member Author

kephale commented Aug 24, 2021

I suspect the jackson issue is because it doesnt inherit properly from scenery's jackson deps

@kephale
Copy link
Member Author

kephale commented Aug 24, 2021

The jackson issue is fixed by updating to:

    <dependency>
      <groupId>ome</groupId>
      <artifactId>formats-gpl</artifactId>
      <version>${formats-gpl.version}</version>
      <exclusions>
        <exclusion>
          <groupId>com.fasterxml.jackson.core</groupId>
          <artifactId>jackson-core</artifactId>
        </exclusion>
        <exclusion>
          <groupId>com.fasterxml.jackson.core</groupId>
          <artifactId>jackson-annotations</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

@kephale kephale marked this pull request as ready for review September 14, 2021 11:30
@kephale kephale merged commit 80d2660 into master Sep 14, 2021
@kephale kephale deleted the jitpack-pom branch September 14, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant