Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle: Declare dependencies correctly for local build #442

Merged
merged 4 commits into from
Jun 11, 2023

Conversation

skalarproduktraum
Copy link
Member

This PR fixes an issue in the Gradle build file where sciview's dependencies were not declared correctly, leading to build failures when building against a local scenery version.

@skalarproduktraum skalarproduktraum added bugfix This PR contains a bugfix build-system Issue or PR concerns build system, dependencies, etc. labels Apr 18, 2023
@kephale kephale merged commit 156b05c into master Jun 11, 2023
3 of 4 checks passed
@kephale kephale deleted the fix/gradle-dependencies-for-local-build branch June 11, 2023 12:19
@kephale
Copy link
Member

kephale commented Jun 11, 2023

Codacy complaint was:

build.gradle.kts
Medium icon Medium Error Prone
Multiple occurrences of the same string literal within a single file detected. Prefer extracting the string literal into a property or constant.

val ktVersion = "1.8.20"

These are duplicated in multiple scopes, but the duplication is OK for me in these cases.

@skalarproduktraum skalarproduktraum added the dd-hackathon-2023 A result of the 2023 Dresden hackathon label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR contains a bugfix build-system Issue or PR concerns build system, dependencies, etc. dd-hackathon-2023 A result of the 2023 Dresden hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants