Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Travis cruft #459

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Remove Travis cruft #459

merged 5 commits into from
Jun 13, 2023

Conversation

ctrueden
Copy link
Member

And clean up a few other small things.

@ctrueden
Copy link
Member Author

OK, the CI failed because BVV depends on JogAmp 2.3.2 -main artifacts, and then it tries to drag in no-longer-existent-in-2.4.0 platform artifacts. At least, I think that's what's going on...

@ctrueden
Copy link
Member Author

I scaled back this PR, so that it no longer updates pom-scijava to the latest 35.1.1 release. We cannot do so until we have new releases of BVV and scenery that really stop using jogamp, or at least fix the included native classifier artifacts to match jogamp 2.4.0.

repositories {
mavenCentral()
maven("https://maven.scijava.org/content/groups/public")
maven("https://jitpack.io")
Copy link
Member

@kephale kephale Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we want to get rid of jitpack because of reproducibility issues and simplifying the maven repo usage? That is fine with me.

I would just share that this is the simplest way to get some of the N5 and BDV artifacts (n5-viewer comes to mind) in a reliable semi-reproducible way, and I am using those artifacts for the OpenOrganelle demo (like here even though it is temporarily commented:

//implementation("com.github.saalfeldlab:n5-viewer:ec0b177")
).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N5 and BDV artifacts are available at release versions from maven.scijava.org. And jitpack is also proxied by the maven.scijava.org public group. I see the value in adding the jitpack repo separately in local dev scenarios. But do we need it for the officially pushed build system?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am aware that they're on scijava maven, but N5 artifact releases are slow compared to the development. There also has been some API change in N5/BDV that requires me to use SNAPSHOTs for doing the advanced stuff that will be required for the sciview paper demo.

I'm still very fine with getting jitpack out of the official build. I'm sure we can nudge folks to get things out of SNAPSHOT stage. I personally was very strongly attached to keeping jitpack in the list because I've often had short amounts of time to work on things, and I ended up losing most of that time just refreshing my dev environment to either locally link projects or do local SNAPSHOT builds. I am convinced that just pointing to a jitpack hash and having it work has saved me hundreds of hours.

Merging.

Copy link
Member

@kephale kephale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. I can re-add jitpack stuff to my branch if I need it, and am fine if the conclusion is that we need to nudge folks to cut releases. ImgLib2 folks are quite fast these days.

@kephale kephale merged commit b4e8688 into master Jun 13, 2023
4 checks passed
@kephale kephale deleted the rm-travis branch June 13, 2023 15:44
@skalarproduktraum skalarproduktraum added dd-hackathon-2023 A result of the 2023 Dresden hackathon bugfix This PR contains a bugfix labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR contains a bugfix dd-hackathon-2023 A result of the 2023 Dresden hackathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants