Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear property editor on delete #463

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Clear property editor on delete #463

merged 2 commits into from
Jun 13, 2023

Conversation

moreApi
Copy link
Member

@moreApi moreApi commented Jun 13, 2023 •
edited

also inputhandler getter methods get cleaned up.

Closes #409

@moreApi
SciView, CameraTranslateControl.kt, ControlPoints.kt, Controls, Help,…
30321a5 
… KEyBindings,Sciview: Remove publicGetInputHandler, made sceneryInputHandler nullable and adjusted consuming code
@moreApi
SwingNodePropertyEditor.kt: display help text on startup and if selec…
0c63674 
…ted node has be deleted
@moreApi moreApi mentioned this pull request Jun 13, 2023
Closed
kephale
kephale approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@kephale kephale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This also has refactors to access scenery's inputHandler better.

@kephale
Copy link
Member

kephale commented Jun 13, 2023

I'm merging to get this in before too much work happens on the property editor.

@kephale kephale merged commit 928f33f into master Jun 13, 2023
4 checks passed
@kephale kephale deleted the clearPropertyEditorOnDelete branch June 13, 2023 13:40
@skalarproduktraum skalarproduktraum added dd-hackathon-2023 A result of the 2023 Dresden hackathon bugfix This PR contains a bugfix labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kephale kephale kephale approved these changes

@skalarproduktraum skalarproduktraum Awaiting requested review from skalarproduktraum

Assignees
No one assigned
Labels
bugfix This PR contains a bugfix dd-hackathon-2023 A result of the 2023 Dresden hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Volumes may not be fully deleted
3 participants
@moreApi @kephale @skalarproduktraum