Improvements to the properties panel to close multiple issues #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kephale
changed the title
|
Some of the other Properties panel changes are more involved, so I'd like to merge this one separately. |
ctrueden
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
@kephale In my view, this seems likely to be fine. I tested sciview with and without these changes, and everything seems to work pretty much the same—at least, all the bugs I found and filed today happen on both the mainline branch and this one, as far as I noticed. LGTM!
| @@ -468,6 +491,10 @@ class Properties : InteractiveCommand() { | |||
| maybeRemoveInput("slicedVolumes", VolumeSelectorWidget.VolumeSelection::class.java) | |||
| } | |||
|
|
|||
| if (node is Line){ | |||
There was a problem hiding this comment.
Oh good, Kotlin decided instanceof → is, huh?
| Concept | Java | Python | Kotlin |
|---|---|---|---|
| referential equality | == |
is |
=== |
| structural equality | equals |
== |
== |
| type equality | instanceof |
isinstance |
is |
skalarproduktraum
added
dd-hackathon-2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175
Closes #439