Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use publishNode when adding children to Nodes #481

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Use publishNode when adding children to Nodes #481

merged 2 commits into from
Jun 14, 2023

Conversation

kephale
Copy link
Member

@kephale kephale commented Jun 14, 2023

Closes #479

@kephale kephale mentioned this pull request Jun 14, 2023
Closed
@kephale kephale mentioned this pull request Jun 14, 2023
Closed
ctrueden
ctrueden approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@ctrueden ctrueden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just had one question about whether there is a way to make the API nicer.

src/main/java/sc/iview/commands/demo/advanced/ShowSegmentationDemo.java Show resolved Hide resolved
@ctrueden ctrueden merged commit 91aa456 into master Jun 14, 2023
4 checks passed
@ctrueden ctrueden deleted the addnode-parent branch June 14, 2023 18:56
@skalarproduktraum skalarproduktraum added dd-hackathon-2023 A result of the 2023 Dresden hackathon bugfix This PR contains a bugfix labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrueden ctrueden ctrueden approved these changes

@skalarproduktraum skalarproduktraum skalarproduktraum requested changes

Assignees
No one assigned
Labels
bugfix This PR contains a bugfix dd-hackathon-2023 A result of the 2023 Dresden hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Child nodes are not updated in tree view
3 participants
@kephale @ctrueden @skalarproduktraum