Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for choosing filename for saving videos #483

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Add support for choosing filename for saving videos #483

merged 2 commits into from
Jun 14, 2023

Conversation

kephale
Copy link
Member

@kephale kephale commented Jun 14, 2023

Closes #460
Closes #331

ctrueden
ctrueden approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@ctrueden ctrueden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clear improvement! I just made one tiny suggestion.

src/main/kotlin/sc/iview/commands/view/StartRecordingVideo.kt Outdated Show resolved Hide resolved
@kephale kephale merged commit bc00b2e into master Jun 14, 2023
4 checks passed
@kephale kephale deleted the video-recording-filename branch June 14, 2023 19:20
@skalarproduktraum skalarproduktraum added dd-hackathon-2023 A result of the 2023 Dresden hackathon enhancement labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrueden ctrueden ctrueden approved these changes

Assignees
No one assigned
Labels
dd-hackathon-2023 A result of the 2023 Dresden hackathon enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video recording needs better handling for filenames Add option to change recording destination
3 participants
@kephale @ctrueden @skalarproduktraum