Use unique names and retain names from filenames #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrueden
approved these changes
Jun 14, 2023
| * @param candidateName a candidate name | ||
| * @return a unique name based on [candidateName] | ||
| */ | ||
| fun generateUniqueName(candidateName: String): String { |
There was a problem hiding this comment.
Thank you for implementing this! ☺
|
I was trying to look at the Codacy issues. It says there are two. But when I click over to the Codacy website, it says there are no new or fixed issues. What am I missing? |
|
Yeah I also don't understand the Codacy complaint. Let's see if it happens again |
|
Aha, missing documentation for some stub functions I added :X I'll add that then merge. |
skalarproduktraum
added
dd-hackathon-2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471