-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use XDG-compliant paths for cache and config files #506
Conversation
Tagging @ctrueden on this because I added a dependency on https://github.com/dirs-dev/directories-jvm, the version number is currently hard coded. I wonder if we already have an equivalent dependency floating around in SciJava? |
@kephale This is a good idea, and I don't think we have another dependency for abiding by the XDG conventions before now. This is something I would like to do in ImageJ2+Fiji in general. I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 in support of this. I just was wondering whether we should make a new class for the sciview options, to help minimize the size of SciView.kt
, and group conceptually related things together. But I'm happy either way; this PR is still a step forward.
* | ||
* @return a [ProjectDirectories] for sciview | ||
*/ | ||
fun getProjectDirectories(): ProjectDirectories { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to gather all sciview options into an options/config class, accessible via sciview.getOptions()
or some such. This class could have the ProjectDirectories
and also have any other state for managing configuration. What do you think? Is there significant other configuration to be managed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mouse and key config is blurred between scenery and sciview, which is part of the issue with folks current input config concerns. I'm looking at the most surgical way of ensuring consistent input controls, but there are a lot of layers here...
Ok, I'm going to merge for now. I created a tracking issue for the idea of creating an overall config/options class: #507 |
Closes #452