Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience node adders, based on issue #497 #521

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

xulman
Copy link
Contributor

@xulman xulman commented Jun 20, 2023

this is a followup of the issue #497, it is

  • deprecating addChild()
  • cosmetics: injecting @Deprecate tag to removeChild()
  • adding a shortcut variant of addNode()

Screenshot_20230620_102702

demo example

			SciView sv = SciView.create();

			Sphere j = new Sphere();
			j.setName("addnode");
			sv.addNode(j, false);
			//NB: renders already but lists not yet in the scene inspector panel

			Sphere s = new Sphere();
			s.setName("addchild");
			sv.addNode(s, j);
			//NB: only now all "pending" added nodes will get listed in the inspector panel

Copy link
Member

@kephale kephale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kephale kephale merged commit 7b35bf6 into scenerygraphics:master Jun 20, 2023
4 checks passed
@xulman xulman deleted the convenience-node-adders branch July 12, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants