Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive options for node deletion, set LUT, and toggle bounding boxes #526

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

kephale
Copy link
Member

@kephale kephale commented Jul 16, 2023

Closes #241

When implementing this I found that the only command where there is a clear need is DeleteNode, but SetLUT also makes sense we just don't have examples where a Volume is a child of another Volume.

However, I do see the potential for other things that can be applied to Node's recursively, like adjusting position through the inspector.

@kephale kephale requested a review from moreApi July 16, 2023 15:08
@kephale kephale changed the title Add recursive options for node deletion and set LUT Add recursive options for node deletion, set LUT, and toggle bounding boxes Jul 16, 2023
@kephale
Copy link
Member Author

kephale commented Jul 16, 2023

Note that I found this issue (#527) when implementing this PR.

Copy link
Member

@moreApi moreApi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kephale kephale merged commit f5bb2c7 into main Jul 20, 2023
3 of 4 checks passed
@kephale kephale deleted the new-recursive-commands branch July 20, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply commands to children of Node's
2 participants