Move arcball target as user translates camera #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove debugging line
xulman
reviewed
Feb 20, 2024
| // Assuming SciView has a method to get the camera and its position | ||
| // And assuming 'targetArcball' is a feature of SciView you want to update | ||
| val currentDistance = sciview.targetArcball.distance // Example to access current distance | ||
| val newTargetPosition = cameraNode!!.spatial().position + cameraNode.forward.mul(currentDistance, Vector3f()) |
There was a problem hiding this comment.
this is nice! I was asking myself how one would preserve the distance to the arcball-ing centre, and by how to update/shift that centre based on the distance to the cam (perspective proj.)... the solution above is cool and a robust way of doing it!
| @@ -286,6 +286,8 @@ class Properties : InteractiveCommand() { | |||
| } | |||
|
|
|||
| // update property fields according to scene node properties | |||
| sciView.setActiveNode(currentSceneNode) | |||
| println("referschSceneNodeInDialog") | |||
There was a problem hiding this comment.
here's maybe one printout forgotten to clutter one's console :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pivoting_arcball.mp4
This PR updates sciview so when the user translates the camera the target of the arcball moves. The previous behavior would jump the user back to the previously selected mode when rotating the camera.
Closes: #541