Inspector improvements #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make transfer function editor part of the volume group
…utton for volumes to prevent superfluous hide/show events for histogram
smlpt
reviewed
Feb 20, 2024
| val newFont = it.font.deriveFont(it.font.size * scale) | ||
| it.font = newFont | ||
|
|
||
| if(it is Container) { |
There was a problem hiding this comment.
Do Container types have visible fonts themselves or are they just meta objects for the hierarchy? If the second is the case, you could put lines 348-349 in an else clause?
smlpt
reviewed
Feb 20, 2024
| @Throws(ModuleException::class) | ||
| override fun buildPanel(inputPanel: InputPanel<JPanel, JPanel>, module: Module) { | ||
| buildPanel(inputPanel, module, false) |
There was a problem hiding this comment.
What is the reason for creating the overloaded function here instead of setting uiDebug: Boolean = false per default?
smlpt
approved these changes
Feb 20, 2024
Yaaaaas! Fight back against the "clean whitespace" propaganda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the inspector in the following ways:
SwingGroupingInputHarvester, the group names are saved to the name of the respective component, such that they are identifiable later on in the lifecycle