Bump scenery 0.10.1 #568
Merged
Bump scenery 0.10.1 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kephale
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Fine by me.
The reason imagej-legacy is there is to get a "normal" IJ UI in the ImageJMain demo, but it may not be worth the headaches that legacy causes. I guess it could be a runtime dep, but I don't feel strongly about it since we'll always be deployed with an imagej-legacy in a proper Fiji installation.
|
I have removed it as it repeatedly has caused me headaches with current Java versions because of the launcher. Which should be gone anyway soon. The ImageJ main demo though still gives you a normal UI, but the Swing one, not the AWT one. |
|
Well isn't that just awtful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps scenery to 0.10.1 and removes the (unnecessary) dependency on legacy ImageJ.