Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh cascade:true, concurrently: true refreshes the underlying mat views without concurrency #276

Closed
yonibaciu opened this issue Feb 15, 2019 · 1 comment · Fixed by #288
Closed

Refresh cascade:true, concurrently: true refreshes the underlying mat views without concurrency #276

yonibaciu opened this issue Feb 15, 2019 · 1 comment · Fixed by #288
Assignees
@derekprior

Comments

@yonibaciu
Copy link

yonibaciu commented Feb 15, 2019 •
edited
Loading

Hi,

concurrently:true is not passed down to refresh_dependencies_for which results in depending mat views being refreshed without concurrency.

def refresh_materialized_view(name, concurrently: false, cascade: false)
  raise_unless_materialized_views_supported
  if cascade
    refresh_dependencies_for(name)
  end
  .
  .
end
derekprior added a commit that referenced this issue Feb 2, 2020
@derekprior
Allow cascading refreshes to be done concurrently
1bbea2d 
Previous to this change, using the cascading refresh behavior did not
also pass through the option to concurrently refresh as one would
expect. This meant that while the named view would be refreshed
concurrently when desired, none of its dependencies would.

Fixes #276
@derekprior derekprior mentioned this issue Feb 2, 2020
Merged
@derekprior
Copy link
Contributor

@yonibaciu - I've opened #288 to fix. Want to give that shot locally to see if it behaves as you would expect?

@derekprior derekprior self-assigned this Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekprior derekprior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow cascading refreshes to be done concurrently scenic-views/scenic
2 participants
@derekprior @yonibaciu