Stop capturing locals #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capturing locals interferes with the benefits we get from locals clearing and was always of questionable utility
scgilardi
force-pushed
the
stop-capturing-locals
branch
from
8c88f4a
to
cee6793
Compare
|
Looks good to me. |
scgilardi
added a commit
that referenced
this pull request
Oct 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the :environment key from the throw context. capturing locals was intended to help with debugging, but interferes with the benefits of locals clearing and I'm not aware of anyone using it for any good purpose. Also should address issue #36.
Please experiment, review and discuss.
Thanks!