-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemd services for scx schedulers #88
Conversation
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general. Few comments (that we can also fix/address them later after this is merged):
- it would be nice if we could automatically detect if the schedulers are installed in
/usr/bin
or/usr/sbin
(in Arch it's the same, but Debian/Ubuntu they are still distinct dirs) StandardOutput=null
seems reasonable for now, it would be nice to have a--quiet
option in each scheduler, that we could use to prevent them to spam too much
@arighi Could you check the latest commit? |
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say "allow to run from PATH", it works also from /usr/local/bin :)
This looks great. A few comments:
|
I do not know if it is possible to create one global file that would enable and disable the service. Nevertheless, I will try to work on it.
In the first version I did not have |
I have no idea. You know a lot more about userland system stuff than I do. That said, please see below.
I agree that the messages don't belong in the system log. That said, requiring the users to change the service file and restart to see the outputs doesn't seem ideal either. There are things like |
I will try to work everything out more in the near future. I am determined to make it work as well as possible. |
@sirlucjan @htejun I think the journal in systemd is already a ring buffer and we should be able to set a limit of the output that want to store, I did a quick search and something like this popped up (totally untested, not sure if it actually works):
|
I checked the entries for the service file and it seems to be working.
|
@arighi If I understood correctly, this is what an example service should look like.
|
As mentioned in the discussion, it would be a good idea to allow users to run schedulers with boot. Systemd services seem to be a good solution.
Example of how the service works: