Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set log size to 10M #93

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

sirlucjan
Copy link
Collaborator

@arighi @htejun @Decave
As mentioned in the previous PR #88 that could help solve the log problem.

@kode54
Copy link

kode54 commented Jan 17, 2024

I see these in my journal when running these updated services:

Jan 16 18:27:20 mrgency systemd[1]: /usr/lib/systemd/system/scx_rustland.service:11: Unknown key name 'SystemMaxUse' in section 'Service', ignoring.
Jan 16 18:27:20 mrgency systemd[1]: /usr/lib/systemd/system/scx_rustland.service:12: Unknown key name 'RuntimeMaxUse' in section 'Service', ignoring.
Jan 16 18:27:26 mrgency systemd[1]: /usr/lib/systemd/system/scx_rustland.service:11: Unknown key name 'SystemMaxUse' in section 'Service', ignoring.
Jan 16 18:27:26 mrgency systemd[1]: /usr/lib/systemd/system/scx_rustland.service:12: Unknown key name 'RuntimeMaxUse' in section 'Service', ignoring.

Looks like these are restricted to specific configuration files:

https://www.freedesktop.org/software/systemd/man/latest/journald.conf.html

@sirlucjan
Copy link
Collaborator Author

@arighi So it's just as I thought. We will have to add a journald configuration file. We need to think this through somehow

@arighi
Copy link
Collaborator

arighi commented Jan 17, 2024

hm... I'm wondering, do we need to move these options inside a [Journal] section? Something like:

[Journal]
SystemMaxUse=5M
RuntimeMaxUse=5M

@sirlucjan
Copy link
Collaborator Author

Those settings that were mentioned in the previous PR are most likely assigned to the journald.conf file. It seems to me that we should not set the journal size globally.

@sirlucjan sirlucjan closed this Jan 17, 2024
@sirlucjan sirlucjan deleted the services-improvements branch January 17, 2024 09:10
@sirlucjan sirlucjan restored the services-improvements branch January 17, 2024 09:12
@sirlucjan sirlucjan deleted the services-improvements branch January 17, 2024 09:12
@Byte-Lab
Copy link
Contributor

@sirlucjan
Copy link
Collaborator Author

@Decave I've to take a look.

@sirlucjan sirlucjan restored the services-improvements branch January 17, 2024 21:27
@sirlucjan sirlucjan reopened this Jan 17, 2024
@sirlucjan
Copy link
Collaborator Author

@kode54 @arighi @htejun @Decave

It seems that everything works well
Screenshot_20240117_231649

@sirlucjan sirlucjan changed the title Set log size to 5M Set log size to 10M Jan 17, 2024
@@ -6,7 +6,9 @@ ConditionPathExists=/sys/kernel/debug/sched/ext
Type=simple
ExecStart=scx_central
Restart=always
StandardOutput=null
StandardOutput=journal
StandardError=journal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these the default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I wasn't sure - I preferred to give just in case

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
@sirlucjan
Copy link
Collaborator Author

@htejun I've removed StandardOutput - because its default value is actually journal. StandardError has a different default value, so I haven't removed it so far.

@Byte-Lab
Copy link
Contributor

Byte-Lab commented Jan 17, 2024

The failure appears to be a double fault that's unrelated to your change or sched_ext: https://pastebin.com/FVJLm1N0.

@Byte-Lab Byte-Lab merged commit dd07c44 into sched-ext:main Jan 17, 2024
1 check failed
@arighi
Copy link
Collaborator

arighi commented Jan 18, 2024

FWIW, tested also on Ubuntu, everything works perfectly, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants