-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set log size to 10M #93
Conversation
I see these in my journal when running these updated services:
Looks like these are restricted to specific configuration files: https://www.freedesktop.org/software/systemd/man/latest/journald.conf.html |
@arighi So it's just as I thought. We will have to add a journald configuration file. We need to think this through somehow |
hm... I'm wondering, do we need to move these options inside a
|
Those settings that were mentioned in the previous PR are most likely assigned to the journald.conf file. It seems to me that we should not set the journal size globally. |
@sirlucjan: Maybe Journal Namespaces could be an option? https://www.freedesktop.org/software/systemd/man/latest/systemd-journald.service.html#Journal%20Namespaces |
@Decave I've to take a look. |
294862a
to
b827716
Compare
@@ -6,7 +6,9 @@ ConditionPathExists=/sys/kernel/debug/sched/ext | |||
Type=simple | |||
ExecStart=scx_central | |||
Restart=always | |||
StandardOutput=null | |||
StandardOutput=journal | |||
StandardError=journal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I wasn't sure - I preferred to give just in case
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
b827716
to
1abd319
Compare
Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
@htejun I've removed StandardOutput - because its default value is actually journal. StandardError has a different default value, so I haven't removed it so far. |
The failure appears to be a double fault that's unrelated to your change or sched_ext: https://pastebin.com/FVJLm1N0. |
FWIW, tested also on Ubuntu, everything works perfectly, thanks! |
@arighi @htejun @Decave
As mentioned in the previous PR #88 that could help solve the log problem.