-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change version of async dep to ~2.6.3 for IE compatibility. #80
Change version of async dep to ~2.6.3 for IE compatibility. #80
Conversation
@mattwelke great work opening the review 👏 @Atinux can we get this approved and release a hotfix 🙏 |
@Atinux ☝️ :prettyplease: |
Can someone merge this? |
Released, sorry for delay, my wife had our newborn child last week |
No problem. Thanks for releasing this today. And congratulations! |
@mattwelke would you be interested to help me maintain this project? |
@Atinux Yes! We'll be using this library at my work for the foreseeable future and it seems to have a narrow, stable focus that will be easy to maintain without too many feature requests. @jcdesousa may be interested too. |
Invited! Could you also tell me you npm username? |
@Atinux NPM username is the same as my GitHub username: |
No worries, just added you :) |
@Atinux
We've been sorting out the Node and IE compatibility issue in #77. By now, we've reached consensus that version 1.6.9 of schema-inspector accidentally had breaking changes because of its udnerlying async dependency.
I think moving from the version 3 branch to version 2 branch of async is a great next step because it resolves the breaking changes issue and async's maintainers have committed to maintaining their version 2 branch with IE compatibility and it will receive patches for CVEs until further notice: caolan/async#1661 (comment)
This PR changes us to 2.6.3 of async, and should keep us on the version 2 branch because of specifiying
~2.6.3
. It doesn't use^2.6.3
, because we don't need new async features, just patches for CVEs. The PR does not increment the version of schema-inspector, because I notice you do the version increment in separate commits, so I'm respecting that pattern.