Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version of async dep to ~2.6.3 for IE compatibility. #80

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Change version of async dep to ~2.6.3 for IE compatibility. #80

merged 1 commit into from
Jun 1, 2020

Conversation

mattwelke
Copy link
Collaborator

@mattwelke mattwelke commented May 28, 2020

@Atinux
We've been sorting out the Node and IE compatibility issue in #77. By now, we've reached consensus that version 1.6.9 of schema-inspector accidentally had breaking changes because of its udnerlying async dependency.

I think moving from the version 3 branch to version 2 branch of async is a great next step because it resolves the breaking changes issue and async's maintainers have committed to maintaining their version 2 branch with IE compatibility and it will receive patches for CVEs until further notice: caolan/async#1661 (comment)

This PR changes us to 2.6.3 of async, and should keep us on the version 2 branch because of specifiying ~2.6.3. It doesn't use ^2.6.3, because we don't need new async features, just patches for CVEs. The PR does not increment the version of schema-inspector, because I notice you do the version increment in separate commits, so I'm respecting that pattern.

@jcdesousa
Copy link
Collaborator

@mattwelke great work opening the review 👏

@Atinux can we get this approved and release a hotfix 🙏

@jcdesousa
Copy link
Collaborator

@Atinux ☝️ :prettyplease:

@jcdesousa
Copy link
Collaborator

jcdesousa commented Jun 1, 2020

Can someone merge this?

@Atinux Atinux merged commit 04b7f7b into schema-inspector:master Jun 1, 2020
@Atinux
Copy link
Collaborator

Atinux commented Jun 1, 2020

Released, sorry for delay, my wife had our newborn child last week

@mattwelke
Copy link
Collaborator Author

No problem. Thanks for releasing this today. And congratulations!

@Atinux
Copy link
Collaborator

Atinux commented Jun 3, 2020

@mattwelke would you be interested to help me maintain this project?

@mattwelke
Copy link
Collaborator Author

@Atinux Yes! We'll be using this library at my work for the foreseeable future and it seems to have a narrow, stable focus that will be easy to maintain without too many feature requests.

@jcdesousa may be interested too.

@Atinux
Copy link
Collaborator

Atinux commented Jun 3, 2020

Invited!

Could you also tell me you npm username?

@mattwelke
Copy link
Collaborator Author

@Atinux NPM username is the same as my GitHub username: mattwelke. I recently remade my NPM account since I used to use one that was shared between personal stuff and my work stuff. So this new one is completely separate from my work stuff and should be safe to use for open source. Let me know if you'd like me to create a dedicated NPM account though. I've never maintained an open source project so I'm not familiar with best practices for NPM accounts for them yet.

@Atinux
Copy link
Collaborator

Atinux commented Jun 3, 2020

No worries, just added you :)

@mattwelke mattwelke deleted the fix-breaking-change-with-async branch June 5, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants