Merge pull request #197 from schemahero/test-matrix

Test matrix
schemahero · May 27, 2020 · 0233dca · 0233dca
2 parents e17cc4a + 7ad55c4
commit 0233dca
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 10 deletions.
diff --git a/.github/workflows/build-and-test.yaml b/.github/workflows/build-and-test.yaml
@@ -34,6 +34,9 @@ jobs:
   test-postgres:
     runs-on: ubuntu-latest
     needs: build
+    strategy:
+      matrix:
+        postgres_version: ["10.13", "11.8", "12.3"]
     steps:
       - uses: actions/checkout@v2
       - name: Download schemahero binary
@@ -42,11 +45,14 @@ jobs:
           name: schemahero
           path: bin/
       - run: chmod +x bin/schemahero
-      - run: make -C integration/tests/postgres run
+      - run: make -C integration/tests/postgres ${{matrix.postgres_version}}
 
   test-mysql:
     runs-on: ubuntu-latest
     needs: build
+    strategy:
+      matrix:
+        mysql_version: ["5.6", "5.7", "8.0"]
     steps:
       - uses: actions/checkout@v2
       - name: Download schemahero binary
@@ -55,11 +61,14 @@ jobs:
           name: schemahero
           path: bin/
       - run: chmod +x bin/schemahero
-      - run: make -C integration/tests/mysql run
+      - run: make -C integration/tests/mysql ${{matrix.mysql_version}}
 
   test-cockroach:
     runs-on: ubuntu-latest
     needs: build
+    strategy:
+      matrix:
+        cockroachdb_version: ["v19.2.7", "v20.1.0"]
     steps:
       - uses: actions/checkout@v2
       - name: Download schemahero binary
@@ -68,7 +77,7 @@ jobs:
           name: schemahero
           path: bin/
       - run: chmod +x bin/schemahero
-      - run: make -C integration/tests/cockroach run
+      - run: make -C integration/tests/cockroach ${{matrix.cockroachdb_version}}
 
   kots:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/tagged-release.yaml b/.github/workflows/tagged-release.yaml
@@ -33,6 +33,9 @@ jobs:
   test-postgres:
     runs-on: ubuntu-latest
     needs: build
+    strategy:
+      matrix:
+        postgres_version: ["10.13", "11.8", "12.3"]
     steps:
       - uses: actions/checkout@v2
       - name: Download schemahero binary
@@ -41,11 +44,14 @@ jobs:
           name: schemahero
           path: bin/
       - run: chmod +x bin/schemahero
-      - run: make -C integration/tests/postgres run
+      - run: make -C integration/tests/postgres ${{matrix.postgres_version}}
 
   test-mysql:
     runs-on: ubuntu-latest
     needs: build
+    strategy:
+      matrix:
+        mysql_version: ["5.6", "5.7", "8.0"]
     steps:
       - uses: actions/checkout@v2
       - name: Download schemahero binary
@@ -54,11 +60,14 @@ jobs:
           name: schemahero
           path: bin/
       - run: chmod +x bin/schemahero
-      - run: make -C integration/tests/mysql run
+      - run: make -C integration/tests/mysql ${{matrix.mysql_version}}
 
   test-cockroach:
     runs-on: ubuntu-latest
     needs: build
+    strategy:
+      matrix:
+        cockroachdb_version: ["v19.2.7", "v20.1.0"]
     steps:
       - uses: actions/checkout@v2
       - name: Download schemahero binary
@@ -67,7 +76,7 @@ jobs:
           name: schemahero
           path: bin/
       - run: chmod +x bin/schemahero
-      - run: make -C integration/tests/cockroach run
+      - run: make -C integration/tests/cockroach ${{matrix.cockroachdb_version}}
 
   goreleaser:
     runs-on: ubuntu-latest

diff --git a/config/crds/v1/databases.schemahero.io_databases.yaml b/config/crds/v1/databases.schemahero.io_databases.yaml
@@ -133,7 +133,7 @@ spec:
                         type: object
                     type: object
                 type: object
-              disableShellCommand:
+              enableShellCommand:
                 type: boolean
               immediateDeploy:
                 type: boolean

diff --git a/config/crds/v1beta1/databases.schemahero.io_databases.yaml b/config/crds/v1beta1/databases.schemahero.io_databases.yaml
@@ -133,7 +133,7 @@ spec:
                       type: object
                   type: object
               type: object
-            disableShellCommand:
+            enableShellCommand:
               type: boolean
             immediateDeploy:
               type: boolean

diff --git a/pkg/installer/database_objects.go b/pkg/installer/database_objects.go
@@ -135,7 +135,7 @@ spec:
                       type: object
                   type: object
               type: object
-            disableShellCommand:
+            enableShellCommand:
               type: boolean
             immediateDeploy:
               type: boolean
@@ -310,7 +310,7 @@ spec:
                         type: object
                     type: object
                 type: object
-              disableShellCommand:
+              enableShellCommand:
                 type: boolean
               immediateDeploy:
                 type: boolean