Update from code review

schemahero · Jan 20, 2020 · 0932895 · 0932895
1 parent 376cc2e
commit 0932895
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/pkg/cli/schemaherokubectlcli/get_migrations.go b/pkg/cli/schemaherokubectlcli/get_migrations.go
@@ -106,7 +106,7 @@ func GetMigrationsCmd() *cobra.Command {
 
 				rows = append(rows, []string{
 					migration.Name,
-					"??",
+					"<Database Unknown>",
 					migration.Spec.TableName,
 					timestampToAge(migration.Status.PlannedAt),
 					timestampToAge(migration.Status.ExecutedAt),

diff --git a/pkg/cli/schemaherokubectlcli/get_tables.go b/pkg/cli/schemaherokubectlcli/get_tables.go
@@ -77,19 +77,6 @@ func GetTablesCmd() *cobra.Command {
 			for _, table := range matchingTables {
 				status := "Current"
 
-				// if len(table.Status.Plans) == 0 {
-				// 	status = "Planning"
-				// 	continue
-				// }
-
-				// for _, plan := range table.Status.Plans {
-				// 	if plan.ExecutedAt == 0 && plan.RejectedAt == 0 && plan.ApprovedAt == 0 {
-				// 		status = "Pending"
-				// 	} else if plan.PlannedAt == 0 {
-				// 		status = "Planning"
-				// 	}
-				// }
-
 				fmt.Fprintln(w, fmt.Sprintf("%s\t%s\t%s", table.Name, table.Spec.Database, status))
 			}
 			w.Flush()