Skip to content

Commit

Permalink
Add table instance as owner of migration object
Browse files Browse the repository at this point in the history
  • Loading branch information
marccampbell committed Apr 5, 2020
1 parent 0ec3dfe commit 1994544
Show file tree
Hide file tree
Showing 28 changed files with 63 additions and 35 deletions.
2 changes: 1 addition & 1 deletion pkg/apis/databases/v1alpha3/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/schemas/v1alpha3/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/clientset.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/fake/clientset_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/fake/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/fake/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/scheme/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/scheme/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/client/schemaheroclientset/typed/schemas/v1alpha3/doc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions pkg/controller/table/objects.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,11 @@ func (r *ReconcileTable) planPod(database *databasesv1alpha3.Database, table *sc
return pod, nil
}

func (r *ReconcileTable) ensureTableConfigMap(desiredConfigMap *corev1.ConfigMap) error {
func (r *ReconcileTable) ensureTableConfigMap(ctx context.Context, desiredConfigMap *corev1.ConfigMap) error {
existingConfigMap := corev1.ConfigMap{}
if err := r.Get(context.Background(), types.NamespacedName{Name: desiredConfigMap.Name, Namespace: desiredConfigMap.Namespace}, &existingConfigMap); err != nil {
if err := r.Get(ctx, types.NamespacedName{Name: desiredConfigMap.Name, Namespace: desiredConfigMap.Namespace}, &existingConfigMap); err != nil {
if kuberneteserrors.IsNotFound(err) {
err = r.Create(context.Background(), desiredConfigMap)
err = r.Create(ctx, desiredConfigMap)
if err != nil {
return errors.Wrap(err, "failed to create configmap")
}
Expand All @@ -153,11 +153,11 @@ func (r *ReconcileTable) ensureTableConfigMap(desiredConfigMap *corev1.ConfigMap
return nil
}

func (r *ReconcileTable) ensureTablePod(desiredPod *corev1.Pod) error {
func (r *ReconcileTable) ensureTablePod(ctx context.Context, desiredPod *corev1.Pod) error {
existingPod := corev1.Pod{}
if err := r.Get(context.Background(), types.NamespacedName{Name: desiredPod.Name, Namespace: desiredPod.Namespace}, &existingPod); err != nil {
if err := r.Get(ctx, types.NamespacedName{Name: desiredPod.Name, Namespace: desiredPod.Namespace}, &existingPod); err != nil {
if kuberneteserrors.IsNotFound(err) {
err = r.Create(context.Background(), desiredPod)
err = r.Create(ctx, desiredPod)
if err != nil {
return errors.Wrap(err, "failed to create table migration pod")
}
Expand Down

0 comments on commit 1994544

Please sign in to comment.