Kots #116
Merged
Kots #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccampbell
force-pushed
the
kots
branch
2 times, most recently
from
5691916
to
753f777
Compare
divolgin
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the v1alpha3 schemahero no longer contains rendered, applyable YAML, this took a little code.
In v1alpha3, the recommend installation path is either
kubectl schemahero installorkubectl. schemahero install --yaml | kubectl apply -f. This PR adds a flag that allows the second option to render the YAML to multiple files on disk. The GitHub action calls this, and renders these into a directory that contains the preflights, support-bundle, config, etc. This will allow the KOTS application to be updated on PR.