Bump client-go and the required deps to 1.18.0 #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller-runtime SHA is the odd one here. Currently controller-runtime is at 0.5.2 which is incompatible with client-go 1.18.0 because:
https://github.com/kubernetes-sigs/controller-runtime/blob/release-0.5/pkg/metrics/client_go_adapter.go#L133 doesn't match https://github.com/kubernetes/client-go/blob/8e91b7aa91b1ac2ad5d144bd602f01d7daa7d187/tools/metrics/metrics.go#L73
This has been fixed, but there's no new release of controller-runtime yet, so using this SHA makes everything compatible. When 0.5.3 is released, we should update.