Initial support for Cassandra #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccampbell
force-pushed
the
cassandra
branch
from
fe1efb3
to
872ca68
Compare
Closed
marccampbell
force-pushed
the
cassandra
branch
11 times, most recently
from
6ed00cc
to
f9256c5
Compare
marccampbell
changed the title
divolgin
reviewed
Sep 21, 2020
|
|
||
| if driver == "" || ddl == "" || uri == "" { | ||
| if driver == "" || ddl == "" || uri == "" || len(host) == 0 { |
There was a problem hiding this comment.
inconsistent style: len(host) == 0 vs host == ""
nm. just got to where the params are defined
divolgin
reviewed
Sep 21, 2020
| if uri == "" { | ||
| missing = append(missing, "uri") | ||
| if len(host) == 0 { |
There was a problem hiding this comment.
this could be an && to save one indentation level
divolgin
reviewed
Sep 21, 2020
|
|
||
| cmd.Flags().String("username", "", "username to use when connecting") | ||
| cmd.Flags().String("password", "", "password to use when connecting") | ||
| cmd.Flags().StringSlice("host", []string{}, "hostname to use when connecting") |
There was a problem hiding this comment.
should this be hosts instead?
There was a problem hiding this comment.
I don't think so... Right now it will be:
kubectl schemahero apply --host 10.1.1.1 --host 10.1.1.2 I think hosts would be weird, IMO
Signed-off-by: Marc Campbell <marc.e.campbell@gmail.com>
marccampbell
force-pushed
the
cassandra
branch
from
f9256c5
to
b99e920
Compare
divolgin
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Cassandra schemas.
This also creates a new CRD for
datatype. This is commonly used in cassandra and should / could also be implemented in other database engines.Docs PR is at schemahero/schemahero-docs#40