Honor the image flag to shell #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `--image` would be overwritten in the case of a mysql or postgres database, preventing one from supplying a version-relevant image to use when debugging Signed-off-by: Matthew L Daniel <md@stoi.cc>
Signed-off-by: Matthew L Daniel <md@stoi.cc>
Signed-off-by: Matthew L Daniel <md@stoi.cc>
marccampbell
approved these changes
Mar 17, 2021
laverya
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the default image for postgres is 11, and my database is 12, it is a hassle that
kubectl schemahero shell my-dbdid not respect the--imageflag provided to it (because using\dtfrom an 11 psql connected to a 12 database yields an error)IJ pointed out the typos in the other
shell.gowhile I was trying to figure out what was going on, so I fixed those, and it similarly advised that the error returned fromviper.BindPFlagswas going to /dev/null -- but those are in separate commits if you don't want them fixed