Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatholicChurch may be subclassOf Church #1605

Closed
Tpt opened this issue Apr 27, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Tpt
Copy link
Contributor

commented Apr 27, 2017

CatholicChurch is currently not a subclassOf Church. It should maybe be one.

Tpt added a commit to Tpt/schemaorg that referenced this issue Apr 27, 2017

@kevinawilson

This comment has been minimized.

Copy link

commented Nov 2, 2017

Instead of making CatholicChurch a subclass of church, I would suggest adding a property "denomination" to Church. This would allow any denomination to be indicated, which would save us from having to create a subclass for each and every denomination (e.g., BaptistChurch, PresbyterianChurch, LutheranChurch).

The issue of denominational affiliation is a difficult one, and it wouldn't make much sense to create a subtype for every variation. For example, over 60 separate Baptist denominations exist in the US alone. Having a property like denomination that accepts any value allows for distinctions between the Southern Baptist, American Baptist, National Baptist, etc. without the need for subclasses (which would never be exhaustive anyway). It would allow churches to indicate their affiliation, even when they belong to a new group for which no class exists.

Another (perhaps more elegant) approach would be to make Church a subclass of Organization as well as Place, since the term "church" refers not only to a building but to the group that meets in that building. If we take this approach, denomination would not need to be added, because the memberOf or parentOrganization properties could indicate the larger denomination to which the church belongs. This would also give it access to other properties of Organization that would be useful (such as employee, foundingDate, etc.). This might also be a good idea for other subclasses of PlaceOfWorship.

@Tpt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2017

I definitely agree about your proposal but it seems a bit off topic here. This task is about making the CatholicChurch class, that already exists, a subclass of Church. It is a change that seems still relevant if we do not remove the CatholicChurch class. Put your proposal in a new task seems more appropriate to me.

@kevinawilson

This comment has been minimized.

Copy link

commented Nov 3, 2017

I had thought about opening a new issue, but when I saw you had already addressed something related I thought it would be worth raising here. I'll try to write up a proposal when I get a chance.

Tpt added a commit to Tpt/schemaorg that referenced this issue Apr 11, 2019

@danbri danbri closed this in #1607 Apr 18, 2019

danbri added a commit that referenced this issue Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.