Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonetaryAmountDistribution example does not match the documentation #2058

Closed
tko opened this issue Sep 11, 2018 · 4 comments
Closed

MonetaryAmountDistribution example does not match the documentation #2058

tko opened this issue Sep 11, 2018 · 4 comments

Comments

@tko
Copy link

tko commented Sep 11, 2018

https://pending.schema.org/MonetaryAmountDistribution

The JSON-LD example on the page contains

  "estimatedSalary": {
    "@type": "MonetaryAmountDistribution",
    "duration": "1Y",
    "currency": "USD",
    "percentile10": 72000,
    "percentile25": 86000,
    "median": 109000,
    "percentile75": 120000,
    "percentile90": 140000
  }

of all the properties only currency is actually documented.

@Aaranged
Copy link

Aaranged commented Sep 12, 2018

These properties are all in pending. E.g.:

However, on another note, for all of these properties the "Used on these types" referenced is QuantitativeValueDistribution. As MonetaryAmountDistribution is not a subtype of QuantitativeValueDistribution (they are both subtypes of QuantitativeValue), these properties wouldn't be valid for MonetaryAmountDistribution.

Accordingly, either MonetaryAmountDistribution should be modelled as a subtype of QuantitativeValueDistribution, or the domain of these properties should be extended to include MonetaryAmountDistribution.

Having written what I did above I see on #1698 that it is the first of these solutions that was indeed proposed by @vholland (emphasis mine): "New type MonetaryAmountDistribution: A subtype of QuantitativeValueDistribution for describing a statistical distribution of monetary amounts."

danbri added a commit that referenced this issue Feb 19, 2019
Fixed a bug - QuantitativeValueDistribution now has correct
supertype, it was mistakenly marked up as QuantitativeValue instead
of StructuredValue.

We also need to check #2058 here
@danbri
Copy link
Contributor

danbri commented Feb 19, 2019

/cc @vholland @rvguha

@vholland
Copy link
Contributor

Yes, the intention was to make MonetaryValueDistribution a subtype of QuantitativeValueDistribution.

@danbri
Copy link
Contributor

danbri commented Feb 25, 2019

Fixed in master branch for next release

@danbri danbri closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants