Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve model for schema:DataType #218

Closed
jaw111 opened this issue Jan 7, 2015 · 4 comments
Closed

Improve model for schema:DataType #218

jaw111 opened this issue Jan 7, 2015 · 4 comments
Assignees
Labels
schema.org vocab General top level tag for issues on the vocabulary

Comments

@jaw111
Copy link
Contributor

jaw111 commented Jan 7, 2015

http://schema.org/DataType

In relation to #217 it would seem from the current hierarchy that schema:DataType is the super-class of schema:Boolean, schema:Date, etc.

This would infer that any literal value is a schema:DataType, which seems illogical.

It would seem more logical that:

  • the existing datatype classes have type schema:DataType rather than be a sub-class of it
  • a top-level class schema:Literal class is introduced (analogous to rdfs:Literal) of which all the existing data types are a sub-class

The result should be something like:

schema:DataType a rdfs:Class ;
  rdfs:subClassOf schema:Class .

schema:Literal a schema:DataType .

schema:Boolean a schema:DataType ;
  rdfs:subClassOf schema:Literal .

schema:Date a schema:DataType ;
  rdfs:subClassOf schema:Literal .
@jaw111 jaw111 changed the title Improve model for schema:Datatype Improve model for schema:DataType Jan 7, 2015
@danbri
Copy link
Contributor

danbri commented Jan 21, 2015

@rvguha can you take a look?

@danbri danbri added this to the sdo-gozer release milestone Jan 21, 2015
@danbri danbri added question schema.org vocab General top level tag for issues on the vocabulary labels Jan 21, 2015
@rvguha
Copy link
Contributor

rvguha commented Apr 17, 2015

Yes, jaw111 is absolutely right. This does mean that DataType is a class of classes.

@rvguha rvguha closed this as completed Apr 17, 2015
@danbri danbri reopened this Apr 17, 2015
@danbri
Copy link
Contributor

danbri commented Apr 17, 2015

Thanks. Re-opened as I'm only closing issues once we've addressed them. We'll need to tweak schema.rdfa here...

danbri added a commit that referenced this issue Apr 30, 2015
…tributes.

This is for cases where we want to give multiple types in the schema config, without verbosity.
This update also takes care to normalize the use of "rdf:type" in @Property to
create the exact same internal structure, i.e. canonicalize to http://schema.org/typeOf.
Intent is to avoid subtle bugs where we have two kinds of type triple depending on which
piece of RDFa syntax is used.

Required for #218 and #130 cleanup of meta-model.
danbri added a commit that referenced this issue Apr 30, 2015
marked as being of 'type' DataType, rather than a subtype of DataType.

We need to update the UI/navigation accordingly.

This is for #218 and #130
@danbri
Copy link
Contributor

danbri commented Apr 30, 2015

The vocab side of this is fixed in sdo-gozer, alongside #130. UI/python consequences of the new structure are tracked as #463.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema.org vocab General top level tag for issues on the vocabulary
Projects
None yet
Development

No branches or pull requests

3 participants