Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EducationalOrganizations should be CivicStructures #2540

Closed
vholland opened this issue Apr 13, 2020 · 4 comments
Closed

EducationalOrganizations should be CivicStructures #2540

vholland opened this issue Apr 13, 2020 · 4 comments
Assignees
@danbri

Comments

@vholland
Copy link
Contributor

From the discussion at https://twitter.com/dannysullivan/status/1248363322912563205

For some reason, educational organizations (universities, elementary schools, etc) are listed under Organization but are not under CivicStructure. It is strange to not consider these physical places as well.

I propose adding CivicStructure as a supertype of EducationalOrganization in addition the the existing Organization. This is similar to the pattern for LocalBusiness.
vholland added a commit to vholland/schemaorg that referenced this issue Apr 13, 2020
@vholland
Issue schemaorg#2540: Made EducationalOrganization a subclass of Civi…
882f15a 
…cStructure
@danbri danbri self-assigned this Apr 14, 2020
@danbri
Copy link
Contributor

danbri commented Apr 14, 2020

This LGTM

Fast-tracking for covid-19 response /cc @tmarshbing @scor @nicolastorzec @tilid @rvguha

@danbri
Copy link
Contributor

danbri commented Apr 14, 2020

#2541 is failing checks

INFO:test_graphs:Term 'http://schema.org/2526' has nonexistent supertype: 'http://schema.org/@@@@'

Merging and fixing

danbri pushed a commit that referenced this issue Apr 14, 2020
@vholland
Issue #2540: Made EducationalOrganization a subclass of CivicStructure (
d2584ad 
#2541)

* Issue #2341: Added SportsTeam to the domain for gender.

* Remove file added to wrong branch.

* Issue #2540: Made EducationalOrganization a subclass of CivicStructure
@danbri
Copy link
Contributor

danbri commented Apr 14, 2020

@vholland maybe you fixed it already? the file in pending seemed ok to me, although as this isn't new vocab I'll move the fix into core.

@vholland
Copy link
Contributor Author

Included in schema.org 7.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbri danbri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danbri @vholland