Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an origin property for Trip (resulted in /tripOrigin) #3317

Closed
gmackenz opened this issue May 19, 2023 · 1 comment
Closed

Create an origin property for Trip (resulted in /tripOrigin) #3317

gmackenz opened this issue May 19, 2023 · 1 comment
Assignees
@danbri
Labels
Queued for Editorial Work Editor needs to turn issues/PRs into final code and release notes.

Comments

@gmackenz
Copy link
Contributor

gmackenz commented May 19, 2023 •
edited

I am proposing adding a new origin that expects Place for Trip which will be used for navigation/directions for Google's local actions for trip activities.

Proposed code:

:origin a rdf:Property ;
    rdfs:label "origin" ;
    :domainIncludes :Trip ;
    :rangeIncludes :Place ;
    rdfs:comment "The location of origin of the trip, prior to any destination(s)." .
gmackenz added a commit to gmackenz/schemaorg that referenced this issue May 19, 2023
@gmackenz
Adding an origin property to Trip
2f2efa8 
This is for issue schemaorg#3317

"I am proposing adding a new origin that expects Place for Trip which will be used for navigation/directions for Google's local actions for trip activities."
@gmackenz gmackenz mentioned this issue May 19, 2023
Merged
@danbri danbri self-assigned this May 19, 2023
@danbri danbri added the Queued for Editorial Work Editor needs to turn issues/PRs into final code and release notes. label May 19, 2023
danbri pushed a commit that referenced this issue Jun 5, 2023
@gmackenz
Adding an origin property to Trip (#3318)
4fd4806 
* Adding an origin property to Trip

This is for issue #3317

"I am proposing adding a new origin that expects Place for Trip which will be used for navigation/directions for Google's local actions for trip activities."

* Update original proposal for "origin" to "tripOrigin"

As per feedback from Dan.
@danbri danbri changed the title Create an origin property for Trip Create an origin property for Trip (resulted in /tripOrigin) Jun 30, 2023
@danbri
Copy link
Contributor

danbri commented Jul 10, 2023

Fixed in 22.0 https://schema.org/docs/releases.html#v22.0

@danbri danbri closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbri danbri

Labels
Queued for Editorial Work Editor needs to turn issues/PRs into final code and release notes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danbri @gmackenz