Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to express room number in Event location #545

Closed
vholland opened this issue May 26, 2015 · 42 comments
Closed

Need a way to express room number in Event location #545

vholland opened this issue May 26, 2015 · 42 comments
Assignees
Labels
dates times and events Describing times, dates and events (and their relationships) schema.org vocab General top level tag for issues on the vocabulary

Comments

@vholland
Copy link
Contributor

For many events, the location includes a room name. Schema.org should support a way to specify the room.

In some cases, rooms have numeric names containing floor and room number. For example, MIT's 26-100.

In other cases, the room name has no location information embedded in it. For example, Stanford's Berg Hall within the Li Ka Shing Center. Schema.org would need separate properties if we want to get to the level of floor number, etc.

@danbri
Copy link
Contributor

danbri commented May 26, 2015

Are you thinking that this would be a property added to PostalAddress, or Place? Or directly on the Event?

Use case seems perfectly reasonable.

@danbri danbri added the schema.org vocab General top level tag for issues on the vocabulary label May 26, 2015
@vholland
Copy link
Contributor Author

I was thinking PostalAddress. However, if people want to be able to add properties to the room (floor number for example), maybe it should be a Place. I was hoping people would chime in before I started working on an implementation.

@mfhepp
Copy link
Contributor

mfhepp commented May 26, 2015

Maybe it is cleaner to first define a subtype schema:Room for schema:Place and then maybe add room-specific properties?

@jvandriel
Copy link

Might I suggest to have a look at how this is resolved in the acocmodation ontology http://ontologies.sti-innsbruck.at/acco/ns.html, something which might help in extending schema.org/Hotel's properties as well?

@mfhepp
Copy link
Contributor

mfhepp commented May 26, 2015

I assume you have seen the "author" line at http://ontologies.sti-innsbruck.at/acco/ns.html ;-) ?

Yes, indeed, I suggest that that ontology should be a starting point for a hotel extension for schema.org, because it is already aligned with additionalProperty and the commercial model in schema.org, i.e. room pricing will be straightforward.

@jvandriel
Copy link

"I assume you have seen the "author" line at..."

Yup, I was just wondering whether you were hesitant in mentioning it yourself, so I thought I might as well go ahead and do it. :)

@danbri danbri added the dates times and events Describing times, dates and events (and their relationships) label May 27, 2015
@vholland vholland self-assigned this Jun 1, 2015
@vholland
Copy link
Contributor Author

vholland commented Jun 1, 2015

I was weighing two options:

  1. Add a roomName to PostalAddress.
    • Pros: Simple markup
    • Cons: A semantic dead end
  2. Something that works with the Accommodation Ontology. Room is a subtype of Place and can be containedIn another Place.
    • Pros: Semantically rich, can hook into other ontologies
    • Cons: The markup is complicated

@mfhepp
Copy link
Contributor

mfhepp commented Jun 4, 2015

FYI: I am working on a pull request for turning the Accommodation Ontology into a proper schema.org extension, which will give us a clear model for rooms in hotels and also other scenarios. Expect it in June.

@vholland
Copy link
Contributor Author

vholland commented Jun 4, 2015

@mfhepp Great! Do you know where you will plug this in? In other words, how can I express an event is in a particular lecture hall at a university?

@mfhepp
Copy link
Contributor

mfhepp commented Jun 4, 2015

I think (not yet firmly) that there will be subtypes of http://schema.org/Place, namely schema.org:HotelRoom and schema:MeetingRoom, or simply schema:Room. roomNumber should then be a property thereof. Then, you can use schema:Event -> location > schema:MeetingRoom -> roomNumber.

How does that sound?

(What we need to fix is how the rooms are included in hotel offers, but I have an idea for that).

@rvguha
Copy link
Contributor

rvguha commented Jun 4, 2015

Not sure what you mean by 'semantic dead end'

guha

On Mon, Jun 1, 2015 at 8:26 AM, vholland notifications@github.com wrote:

I was weighing two options:

Add a roomName to PostalAddress.
- Pros: Simple markup
- Cons: A semantic dead end
2.

Something that works with the Accommodation Ontology. Room is a
subtype of Place and can be containedIn another Place.
- Pros: Semantically rich, can hook into other ontologies
- Cons: The markup is complicated


Reply to this email directly or view it on GitHub
#545 (comment)
.

@vholland
Copy link
Contributor Author

vholland commented Jun 5, 2015

@rvguha I meant that if we go with a roomName property, we can't later add the capacity of the room or other properties.

@vholland
Copy link
Contributor Author

vholland commented Jun 5, 2015

@mfhepp It sounds promising. It would be nice to support the simple case of schema:Room, so we don't have to enumerate all of the possible room types.

@Aaranged
Copy link

Aaranged commented Jun 5, 2015

+1 to suggestion from @mfhepp.

Re "simple case of schema:Room" wouldn't it be possible to create that, and
the required property "roomNumber" without needing to enumerate more
specific sub-types?

On Fri, Jun 5, 2015 at 7:32 AM, vholland notifications@github.com wrote:

@mfhepp https://github.com/mfhepp It sounds promising. It would be nice
to support the simple case of schema:Room, so we don't have to enumerate
all of the possible room types.


Reply to this email directly or view it on GitHub
#545 (comment)
.

@mfhepp
Copy link
Contributor

mfhepp commented Jun 5, 2015

I actually think we will need all three - schema:Room (any room), schema:HotelRoom (a room for temporary lodging), and schema:MeetingRoom. But let's wait for my accommodation proposal. It should also cover this issue.

Martin


martin hepp http://www.heppnetz.de
mhepp@computer.org @mfhepp

On 05 Jun 2015, at 21:45, Aaron Bradley notifications@github.com wrote:

+1 to suggestion from @mfhepp.

Re "simple case of schema:Room" wouldn't it be possible to create that, and
the required property "roomNumber" without needing to enumerate more
specific sub-types?

On Fri, Jun 5, 2015 at 7:32 AM, vholland notifications@github.com wrote:

@mfhepp https://github.com/mfhepp It sounds promising. It would be nice
to support the simple case of schema:Room, so we don't have to enumerate
all of the possible room types.


Reply to this email directly or view it on GitHub
#545 (comment)
.


Reply to this email directly or view it on GitHub.

@akuckartz
Copy link

@mfhepp Any news regarding schema:Room ?

@mfhepp
Copy link
Contributor

mfhepp commented Jul 13, 2015

Pretty high on my todo-list, but still pending ;-)

On 09 Jul 2015, at 19:48, Andreas Kuckartz notifications@github.com wrote:

@mfhepp Any news regarding schema:Room ?


Reply to this email directly or view it on GitHub.

@danbri
Copy link
Contributor

danbri commented Sep 29, 2015

ping @mfhepp - anything to share?

@mfhepp
Copy link
Contributor

mfhepp commented Sep 29, 2015

room number will be in the hotel pull request, preview:

http://sdo-hotels.appspot.com/roomNumber

will be finished and shared officially today.

@mfhepp
Copy link
Contributor

mfhepp commented Sep 29, 2015

Currently, we have

http://sdo-hotels.appspot.com/HotelRoom
and
http://sdo-hotels.appspot.com/MeetingRoom

I could add a generic "Room" supertype if that helps in other applications. We could also merge all of them into one Room type, but actually I think the distinctions matter (HotelRooms have beds, MeetingRooms are a very particular kind of room often offered by business hotels).

Shall I add a Room supertype to the hotels proposal?

@RichardWallis
Copy link
Contributor

Whilst we are changing PostalAddress we should add 'apartment' or similar.

On Tue, Sep 29, 2015 at 1:20 PM, Martin Hepp notifications@github.com
wrote:

Currently, we have

http://sdo-hotels.appspot.com/HotelRoom
and
http://sdo-hotels.appspot.com/MeetingRoom

I could add a generic "Room" supertype if that helps in other
applications. We could also merge all of them into one Room type, but
actually I think the distinctions matter (HotelRooms have beds,
MeetingRooms are a very particular kind of room often offered by business
hotels).

Shall I add a Room supertype to the hotels proposal?


Reply to this email directly or view it on GitHub
#545 (comment)
.

@RichardWallis
Copy link
Contributor

Shall I add a Room supertype to the hotels proposal?

+1

@danbri
Copy link
Contributor

danbri commented Sep 29, 2015

@mfhepp can you make roomNumber work on PostalAddress? @vholland would that help here?

@mfhepp
Copy link
Contributor

mfhepp commented Sep 29, 2015

@danbri @vholland yes, no problem. will be included.

@vholland
Copy link
Contributor Author

+1 to a generic Room type for the odd cases we don't want to enumerate.

Yes, adding roomNumber to PostalAddress helps.

@rvguha
Copy link
Contributor

rvguha commented Sep 29, 2015

Why do we need such a super type? How is such a generic room different from
say, my dining room?

guha

On Tue, Sep 29, 2015 at 5:20 AM, Martin Hepp notifications@github.com
wrote:

Currently, we have

http://sdo-hotels.appspot.com/HotelRoom
and
http://sdo-hotels.appspot.com/MeetingRoom

I could add a generic "Room" supertype if that helps in other
applications. We could also merge all of them into one Room type, but
actually I think the distinctions matter (HotelRooms have beds,
MeetingRooms are a very particular kind of room often offered by business
hotels).

Shall I add a Room supertype to the hotels proposal?


Reply to this email directly or view it on GitHub
#545 (comment)
.

@vholland
Copy link
Contributor Author

My thinking for a generic super type was that there are a lot cases we probably don't want to enumerate. For example, hotel ballrooms and movie theater screening rooms sometimes have room numbers. We could called these "meeting rooms", but it seems easier to have a super type.

@chaals
Copy link
Contributor

chaals commented Sep 29, 2015

I'm not sure about adding different types of rooms. I wonder if I can book Guha's dining room for a wild party - but even if not, I don't think the room type is the key bit there so much as the service provided in the first place (e.g. hotel, fitness centre, sauna, restaurant, business centre - all of which might be available in a typical expensive hotel in most countries I have visited).

The standard spanish or russian address both often require street number, building number, entrance number, floor number, and actual door number. At my basic street address I live in one of half a dozen apartments numbered 1B - which is recognised by most people as short hand for Floor: 1º Door: B but is often recorded in long form.

There are "extra instructions" of all kinds. E.g. for delivery addresses:
"To attention RV Guha, I'd like to book your dining room with double bunk beds for my next visit to California…"

Addresses are hard.

(NB @mfhepp I'm not sure what a CaliforniaKing is compared to other kinds, but "twin" beds are extremely common in Europe at least, and bunkbeds are not that uncommon in places people book as if they were hotels).

@vholland
Copy link
Contributor Author

It seems like there are two use cases for "roomNumber":

  1. Navigating to the building/floor/room where an event is being held whether that is a gala in a ballroom or dinner in Guha's dining room.
  2. Reserving a hotel room or some other accommodation.

Can we split these use cases to make progress on each in parallel?

For the first, adding "roomNumber" (or some other property name) to PostalAddress seems sufficient. As @chaals said, addresses are hard.

For the second, we should run through some use cases to determine what information is already up on the web that could use markup.

@chaals
Copy link
Contributor

chaals commented Sep 29, 2015

For the first - finding a place in more detail, I think we want something like "moreInformation" - which is what people who do deliveries tend to have, allowing you to put "attention So-and-so" or "use the key under the doormat to open the chiimney cover, let yourself in, drink the whisky and leave the presents", or "door number 37A, hidden behind the door numbered 30s" or whatever.

For the second, I don't think this is what we are looking for. You reserve something, you get a place, which has an address or way to identify it, and you get a service (accommodation, wedding, schema.org development lesson, …). What you are reserving is more part of a service description - and that is where e.g. @mfhepp 's hotel extension giving more precise detail will actually be useful.

@vholland
Copy link
Contributor Author

Where are we on this? Can we break the larger proposal down into smaller parts so we can move forward?

@mfhepp
Copy link
Contributor

mfhepp commented Nov 12, 2015

Room number is in the hotel proposal

http://sdo-hotels.appspot.com/Room

http://sdo-hotels.appspot.com/roomNumber

I will finalize the proposal and send a pull request shortly.

Martin


martin hepp http://www.heppnetz.de
mhepp@computer.org @mfhepp

On 11 Nov 2015, at 17:47, vholland notifications@github.com wrote:

Where are we on this? Can we break the larger proposal down into smaller parts so we can move forward?


Reply to this email directly or view it on GitHub.

@mfhepp
Copy link
Contributor

mfhepp commented Nov 12, 2015

Chaals:

On 29 Sep 2015, at 16:01, chaals notifications@github.com wrote:

(NB @mfhepp I'm not sure what a CaliforniaKing is compared to other kinds, but "twin" beds are extremely common in Europe at least, and bunkbeds are not that uncommon in places people book as if they were hotels).

I have changed that in the proposal - you can now either use a text for the bed type or create your own instance of a http://sdo-hotels.appspot.com/BedType and attach a name, description, and image.

This is a simpler mechanism than having hard-wired enumerations in the vocabulary but still allows adding images and descriptions to bed types.

Martin

@RichardWallis
Copy link
Contributor

Still think it would be useful to add roomNumber to Address.

~Richard.

On Thu, Nov 12, 2015 at 10:40 AM, Martin Hepp notifications@github.com
wrote:

Room number is in the hotel proposal

http://sdo-hotels.appspot.com/Room

http://sdo-hotels.appspot.com/roomNumber

I will finalize the proposal and send a pull request shortly.

Martin


martin hepp http://www.heppnetz.de
mhepp@computer.org @mfhepp

On 11 Nov 2015, at 17:47, vholland notifications@github.com wrote:

Where are we on this? Can we break the larger proposal down into smaller
parts so we can move forward?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#545 (comment)
.

@danbri
Copy link
Contributor

danbri commented Nov 17, 2015

@mfhepp - can you file an issue for the hotel room / accomodation topic, so that when the pull request comes it addresses the problem recorded in the issue? Am I right that we don't have a PR for http://sdo-hotels.appspot.com/docs/hotels.html yet? Is https://github.com/mfhepp/schemaorg/tree/hotels the place where it is being developed?

@couloir007
Copy link

I work for a museum, and would like to add room to events, and I'm trying to follow along here. Is the Room location in sdo-hotels proposed for Schema.org and not official yet, or is some subset for hotels only? Seeing this has all happened recently, I can understand if it still fails verification with Google.

Thank you,
Sean

@Aaranged
Copy link

Aaranged commented Jan 7, 2016

@couloir007 A more specific type of room in sdo-hotels is:
http://sdo-hotels.appspot.com/MeetingRoom
... which might meet your needs.

However, as per the breadcrumb path above "Room" is currently constituted as a more specific type of:
http://sdo-hotels.appspot.com/Accommodation

Pinging @philbarker - I strongly suspect, based on my prior work on modelling brick-and-mortar courses, that a "Room" property will also be required by the course schema(s), since the current scope of the course extension encompasses "any type of educational course".

@mfhepp
Copy link
Contributor

mfhepp commented Jan 7, 2016

Note that the fact that MeetingRoom is a subtype of Accommodation should not bother you, because the latter is essentially anything that can accommodate human beings, see the definition:

"An accommodation is a place that can accommodate human beings, e.g. a hotel room, a camping pitch, or a meeting room. Many accommodations are for overnight stays, but this is not a mandatory requirement. For more specific types of accommodations not defined in schema.org, one can use additionalType with external vocabularies."

Martin


martin hepp http://www.heppnetz.de
mhepp@computer.org @mfhepp

On 07 Jan 2016, at 21:28, Aaron Bradley notifications@github.com wrote:

@couloir007 A more specific type of room in sdo-hotels is:
http://sdo-hotels.appspot.com/MeetingRoom
... which might meet your needs.

However, as per the breadcrumb path above "Room" is currently constituted as a more specific type of:
http://sdo-hotels.appspot.com/Accommodation

Pinging @philbarker - I strongly suspect, based on my prior work on modelling brick-and-mortar courses, that a "Room" property will also be required by the course schema(s), since the current scope of the course extension encompasses "any type of educational course".


Reply to this email directly or view it on GitHub.

@mfhepp
Copy link
Contributor

mfhepp commented Jan 7, 2016

The hotels extension is not yet part of the live version of schema.org, but I hope we can get it into the next release.

Martin

martin hepp http://www.heppnetz.de
mhepp@computer.org @mfhepp

On 07 Jan 2016, at 17:48, Sean Montague notifications@github.com wrote:

I work for a museum, and would like to add room to events, and I'm trying to follow along here. Is the Room location in sdo-hotels proposed for Schema.org and not official yet, or is some subset for hotels only? Seeing this has all happened recently, I can understand if it still fails verification with Google.

Thank you,
Sean


Reply to this email directly or view it on GitHub.

@couloir007
Copy link

Thank you for the responses. I've commented out the Room for now until it validates, but probably doesn't much matter at this point. Being new to Schema.org, I'm still learning how best to implement it. Would the Room an event takes place in at a Museum be containedInPlace, as in the event is in a Room with an address at a Museum, or at a Museum with an address that containsPlace Room?

@Aaranged
Copy link

Aaranged commented Jan 8, 2016

Thanks @mfhepp. While I've doubtlessly got the modelling backwards, could this schema conceivably be employed in this fashion to declare a room location?

<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "SocialEvent",
  "name": "Vocabulary Builders Meetup",
  "startDate": "2016-02-14T21:30",
  "location": {
    "@type": "MeetingRoom",
    "roomNumber": "DV 1146",
    "containedInPlace": {
      "@type": "Place",
      "name": "William G. Davis Building",
      "address": {
        "@type": "PostalAddress",
        "addressLocality": "Mississauga",
        "addressRegion": "ON",
        "postalCode": "L5L 1C6",
        "streetAddress": "3359 Mississauga Rd"
      }
    }
  }
}
</script>

@vholland
Copy link
Contributor Author

If this hasn't been needed in 4 years, we can probably close the issue until there is a driving use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dates times and events Describing times, dates and events (and their relationships) schema.org vocab General top level tag for issues on the vocabulary
Projects
None yet
Development

No branches or pull requests

10 participants