Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price - currency issues #1676

Closed
wants to merge 2 commits into from
Closed

Conversation

CEWebDesign
Copy link

@CEWebDesign CEWebDesign commented Jun 26, 2017

Price/currency issues

Price - currency issues
@danbri
Copy link
Contributor

danbri commented May 1, 2018

Thanks for the suggestion. It seems that most (all?) of these are about bringing our syntax into an XML-friendly flavour of HTML. Much as I am fond of XML it seems the world has moved the other way and people aren't self-closing their tags in the HTML5 world. I don't think we are going to re-ignite those debates by trying to enforce XHTML compatibility here (see also "itemscope" in Microdata, e.g. latest WD for W3C's version, https://w3c.github.io/microdata/ ). Are there cases here that go beyond a preference for XHTML-style tag structures? /cc @unor

@CEWebDesign
Copy link
Author

Thanks for looking at this. Just tried to edit inconsistencies stated as invalid in #1678 by @unor . So nothing beyond that as far as I can remember.

@unor
Copy link
Contributor

unor commented May 1, 2018

The slash in the start tag of void elements (img, meta etc.) is

So it could be argued that having the slash is preferable, because it’s valid in both syntaxes, and the only downside for the HTML syntax is having one/two more characters per void element.

I think both ways are fine. Nothing wrong with showing only slashless HTML-syntax examples, nothing wrong with showing examples that work in both syntaxes.

@danbri This PR seems to fix a few other things, too, though (e.g., cases where lowPrice contains a currency symbol). Not sure how to handle this in the best way … I could comment the fixes that, in my opinion, are important, if that helps. Or should a new commit be made?


@CEWebDesign I didn’t intend to imply in #1678 that meta elements must have a slash. I just stated that the two example meta elements are valid like that :)

@CEWebDesign
Copy link
Author

Thank you, so nothing wrong with showing both slash and slash-less examples either?
Maybe a hint will be helpful, because of the importance of void elements for schema.org?
If a hint is given, just slash-less examples are fine, because it is not schema.org to support XHTML. But with slash to be valid in both syntaxes or having both for better diversity are good arguments too. I would prefer having the slash because it is valid for most users when they copy and paste examples.

Hint suggestions:
a) "Examples are both in HTML and XHTML syntax. End slashes in the start tag of void elements (img, meta, link etc.) are optional in HTML syntax and required in XHTML syntax."

b) "Examples are with end slashes in the start tag of void elements (img, meta etc.) to validate in HTML and XHTML syntax. End slashes in the start tag of void elements (img, meta, link etc.) are optional in HTML syntax and required in XHTML syntax."

c) "Examples are without end slashes in the start tag of void elements (img, meta etc.). End slashes in the start tag of void elements (img, meta, link etc.) are optional in HTML syntax and required in XHTML syntax."

Or just
d) "End slashes in the start tag of void elements (img, meta, link etc.) are optional in HTML syntax and required in XHTML syntax."

@unor Yes, there are other fixes. Thank you for reminder. Maybe there should be an extra commit for these fixes?

@github-actions
Copy link

This pull request is being tagged as Stale due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Jul 21, 2020
@RichardWallis RichardWallis changed the base branch from master to main July 23, 2020 13:06
@github-actions github-actions bot closed this Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants