Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR2250 - Enum rationalise #2443

Merged
merged 2 commits into from Jan 22, 2020
Merged

Revert PR2250 - Enum rationalise #2443

merged 2 commits into from Jan 22, 2020

Conversation

RichardWallis
Copy link
Contributor

Revert config to preserve previous definition files so we can revisit later.

@Eyas
Copy link

Eyas commented Jan 21, 2020

👍 I was looking at the current 6.0 schema on webschemas.org, and some of the rationalization was interesting:

  • DrugClass has a type MedicalEnumeration (which has typically meant a value is an enum value) but appears in domainIncludes of the drugClass category as a type in and of itself.
    • If DrugClass is referenced as a type, then it should have the rdf:type of rdfs:Class

@danbri danbri merged commit 0b80408 into master Jan 22, 2020
@danbri
Copy link
Contributor

danbri commented Jan 22, 2020

Ok, we are reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants