Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Disable explicit examples generation if the "explicit" phase is excluded #905

Closed
Stranger6667 opened this issue Dec 3, 2020 · 0 comments · Fixed by #959
Closed

[BUG] Disable explicit examples generation if the "explicit" phase is excluded #905

Stranger6667 opened this issue Dec 3, 2020 · 0 comments · Fixed by #959
Assignees
@Stranger6667
Labels
Difficulty: Beginner Ideal for newcomers Priority: Low Cosmetic or low-impact changes Type: Bug Errors or unexpected behavior

Comments

@Stranger6667
Copy link
Member

Describe the bug
If the "explicit" phase is excluded, then examples should not be generated altogether. E.g. if the --hypothesis-phases=generate,shrink is passed. They still won't be executed by Hypothesis, but Schemathesis "fills the gaps" in examples by invoking strategy.example there (which also might be not the best idea anyway) and may fail on generating examples that won't be executed anyway
@Stranger6667 Stranger6667 added Type: Bug Errors or unexpected behavior Status: Needs Triage Requires initial assessment to categorize and prioritize labels Dec 3, 2020
@Stranger6667 Stranger6667 self-assigned this Dec 3, 2020
@Stranger6667 Stranger6667 changed the title [BUG] [BUG] Disable explicit examples generation if the "explicit" phase is excluded Dec 3, 2020
@Stranger6667 Stranger6667 added Difficulty: Beginner Ideal for newcomers Priority: Low Cosmetic or low-impact changes and removed Status: Needs Triage Requires initial assessment to categorize and prioritize labels Dec 5, 2020
Stranger6667 added a commit that referenced this issue Dec 26, 2020
@Stranger6667
fix: Skip explicit examples generation if this phase is disabled via …
7479c7c 
…config

Ref: #905
@Stranger6667 Stranger6667 mentioned this issue Dec 26, 2020
Merged
Stranger6667 added a commit that referenced this issue Dec 26, 2020
@Stranger6667
fix: Skip explicit examples generation if this phase is disabled via …
afa3daa 
…config

Ref: #905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stranger6667 Stranger6667

Labels
Difficulty: Beginner Ideal for newcomers Priority: Low Cosmetic or low-impact changes Type: Bug Errors or unexpected behavior
Projects
None yet
Milestone
No milestone
1 participant
@Stranger6667