Merge pull request #30 from Aftonbladet/issue26_localstorageRemoveItem

Localstorage only removes single item, instead of clearing entire cache
schibsted · Nov 30, 2015 · da2fb23 · da2fb23
2 parents 878ca0f + 23dbef3
commit da2fb23
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/spid-localstorage.js b/src/spid-localstorage.js
@@ -25,7 +25,7 @@ function set(key, value, expiresInSeconds) {
 
 function clear(key) {
     try {
-        window.localStorage.clear(key);
+        window.localStorage.removeItem(key);
     } catch(e) {
         log.info(e);
     }

diff --git a/test/spec/spid-localstorage_test.js b/test/spec/spid-localstorage_test.js
@@ -17,6 +17,20 @@ describe('SPiD.Localstorage', function() {
         assert.isNull(storage.get('test'));
     });
 
+    it(' clear only clears one key', function () {
+
+        var preExistingKey = 'a';
+        var valueStored = 'foo';
+        storage.set(preExistingKey, valueStored);
+
+        storage.set('b');
+        storage.clear('b');
+
+        var preExistingValueRead = storage.get('a');
+
+        assert.equal(valueStored, preExistingValueRead);
+    });
+
     it(' passing an expires parameter should add expires field that\'s in the future', function() {
         var data = {'thought' : 'leader'};
         storage.set('test', data, 100);
@@ -39,5 +53,4 @@ describe('SPiD.Localstorage', function() {
         assert.isNull( window.localStorage.getItem('test'));
     });
 
-
 });