This repository has been archived by the owner on Sep 10, 2019. It is now read-only.
Localstorage only removes single item, instead of clearing entire cache #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -25,7 +25,7 @@ function set(key, value, expiresInSeconds) { | |||
|
|
|||
| function clear(key) { | |||
There was a problem hiding this comment.
We should maybe look into renaming this function name as well.
There was a problem hiding this comment.
Maybe, I wasn´t bold enough to make any changes more than needed.
I think the name might be there because it was called 'clear' in the cookie module.
If changed it think it should be changed there as well
There was a problem hiding this comment.
I'm thinking that renaming the method is probably a thing for a separate PR (as that's more an issue of style), if we decide that it's the right thing to do.
|
Thanks for finding this and submitting a pull request. |
Andersos
added a commit
that referenced
this pull request
Nov 30, 2015
Localstorage only removes single item, instead of clearing entire cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #29
Please, this is a very serious bug, so it would be great if you could get this released soon and deprecate any other 2.x releases.
The consequence of this bug was that as soon as session is refreshed using the local storage module, the entire localstorage was wiped.