Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined $S3_PREFIX results in nameless directory in s3 #59

Closed
willdady opened this issue Jan 18, 2017 · 2 comments · Fixed by #127 or fleadope/dockerfiles#1
Closed

Undefined $S3_PREFIX results in nameless directory in s3 #59

willdady opened this issue Jan 18, 2017 · 2 comments · Fixed by #127 or fleadope/dockerfiles#1

Comments

@willdady
Copy link

As per the title, by not setting S3_PREFIX I assumed all backups would go into the root of my dedicated backup bucket however the backup files end up under an unnamed directory when viewing the AWS S3 console.

cat dump.sql.gz | aws s3 cp - s3://$S3_BUCKET/$S3_PREFIX/$(date +"%Y-%m-%dT%H:%M:%SZ").sql.gz || exit 2

I assume the extraneous / needs to be removed if $S3_PREFIX isn't provided.
@schickling
Copy link
Owner

Would you mind providing a PR for this?

@danimbrogno danimbrogno mentioned this issue Jan 25, 2017
Open
@acim
Copy link

acim commented Feb 23, 2019

It would be also nice to have date as S3_PREFIX, for example value of "date --rfc-3339=date" output.

blz-ea added a commit to blz-ea/dockerfiles that referenced this issue Feb 4, 2020
@blz-ea
Update postgres-backup-s3
e136046 
- Bump alpine from 3.9 to 3.11
- Add Postgres v12 support (Fixes schickling#115)
- Add multiple or all databases backup (Fixes schickling#10)
- S3_PREFIX can be empty (Fixes schickling#59)
- Add missing Documentation (Fixes schickling#87)
@blz-ea blz-ea mentioned this issue Feb 4, 2020
Merged
@fleadope fleadope mentioned this issue Jul 11, 2021
Merged
iloveitaly pushed a commit that referenced this issue Jan 21, 2022
@blz-ea
Update postgres-backup-s3 (#127)
35e5600 
- Bump alpine from 3.9 to 3.11
- Add Postgres v12 support (Fixes #115)
- Add multiple or all databases backup (Fixes #10)
- S3_PREFIX can be empty (Fixes #59)
- Add missing Documentation (Fixes #87)
Jblew pushed a commit to Jblew/postgres-backup-s3 that referenced this issue Feb 8, 2022
@blz-ea
Update postgres-backup-s3 (schickling#127)
0f1a2bf 
- Bump alpine from 3.9 to 3.11
- Add Postgres v12 support (Fixes schickling#115)
- Add multiple or all databases backup (Fixes schickling#10)
- S3_PREFIX can be empty (Fixes schickling#59)
- Add missing Documentation (Fixes schickling#87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update postgres-backup-s3 blz-ea/dockerfiles
Update postgres-backup-s3 blz-ea/dockerfiles
3 participants
@willdady @schickling @acim