Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace babel polyfill with transform runtime #49

Closed
wants to merge 4 commits into from
Closed

Replace babel polyfill with transform runtime #49

wants to merge 4 commits into from

Conversation

scmx
Copy link

@scmx scmx commented May 21, 2017 •
edited
Loading

No description provided.

@scmx
Copy link
Author

scmx commented May 21, 2017

Note: The commit message might be a bit confusing, it doesn't fix all of #42, just #42 (comment)
I can squash and force-push if you want and remove the reference, or you could use squash during merge.

@scmx
Copy link
Author

scmx commented May 21, 2017 •
edited
Loading

I'm not able to reproduce the CI failure error locally Error: Cannot find module 'babel-runtime/regenerator'. Perhaps it means the babel-runtime has to be an explicit dependency as well? https://babeljs.io/docs/plugins/transform-runtime/

scmx added 2 commits May 21, 2017 23:04
@scmx
Merge branch 'master' into replace-babel-polyfill-with-transform-runtime
16bfb26 
* master:
  Formatting.
  Fix schmich#46: Make backgroundScan default to true.
  streamUrl -> stream
  Removed usage of window.URL.createObjectURL(...) in favour of returning stream directly. This has been done, since createObjectURL has been deprecated (and using it breaks WebRTC functionality when using webrtc-adapter)
  Add note about iOS non-compatibility.
  Improve scanner options formatting.
  Rename VideoAccessError to MediaError.
  Update README to include getUserMedia error handling.
  Add error handling to README example.
  Remove old app. Update deployment commit message.
  Add VideoAccessError to wrap errors from getUserMedia. Update demo to handle errors correctly.
  Add Travis support with deployments.
  Add demo link to README.
  Do not make demo video fullscreen.
  Fix camera name bug in demo.
  Add GitHub Pages project demo.
  Update example to include message when no cameras are found.
  Rename gulp 'dist' target to 'release'.
  var -> let
  Add release publication workflow.
@scmx
Add babel-runtime as explicit dependency
0fdcae6 
See instructions: https://babeljs.io/docs/plugins/transform-runtime/
@pacoccino pacoccino mentioned this pull request Jul 24, 2017
Open
@PallasKatze PallasKatze mentioned this pull request Sep 19, 2017
Open
@scmx scmx closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@scmx